Modify

Opened 8 days ago

Closed 6 days ago

Last modified 4 days ago

#19930 closed defect (fixed)

Warning "oneway=yes is unnecessary for waterway" is incorrect; has lead to deletion of valid data

Reported by: multimodaal <multimodaal@…> Owned by: team
Priority: normal Milestone: 20.10
Component: Core validator Version: latest
Keywords: unnecessary tag false positive waterway oneway Cc:

Description

JOSM validator gives a warning for a waterway with the tag "oneway=yes".
This warning is incorrect: seamarks can be used to create a legal obligation to follow a certain direction just as on a highway.

And also from the point of waterflow waterways do no necessarily run in one direction; waterways here run in one direction or another, depending on the measures in water manegement

This validator rule leads to deletion of valid data from our database, so please delete this rule in next update, thanks!!

Example
Oneway for boats from survey: https://www.mapillary.com/map/im/iq5vgMIIa0aD2cMST9IlXA

This correct tag was added in v3 and deleted in v6 by a JOSM-user doing a type of building import (BAG ) for which the JOSM-validator is used.

Changeset:
https://www.openstreetmap.org/changeset/79200184

Way history:
https://osmlab.github.io/osm-deep-history/#/way/604073901

Attachments (0)

Change History (8)

comment:1 Changed 7 days ago by skyper

Keywords: waterway oneway added

comment:2 Changed 7 days ago by Klumbumbus

Milestone: 20.10
Priority: majornormal

comment:3 Changed 6 days ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17209/josm:

see #15667, fix #19930 - Downgrade warning about oneway on waterway to info level for navigable waterways

comment:4 in reply to:  3 ; Changed 4 days ago by multimodaal <multimodaal@…>

Replying to Klumbumbus:

In 17209/josm:

see #15667, fix #19930 - Downgrade warning about oneway on waterway to info level for navigable waterways

Thx! Does this mean that
-this tag isn't called "unnecessary" by the validator for navigable waterways anymore (also not on the "info level")?
-these tags can no longer be automatically deleted by pushing the "fix" button in the validator?

Best regards (-:

comment:5 in reply to:  4 ; Changed 4 days ago by Klumbumbus

Replying to multimodaal <multimodaal@…>:

-this tag isn't called "unnecessary" by the validator for navigable waterways anymore (also not on the "info level")?

  • non navigable waterway are in warning level with "oneway on suspicious object"
  • navigable waterway are in info level with "waterway together with oneway. The flow direction is defined by the way direction. Use oneway on waterway only in the rare case of a access restriction." This is to help finding waterways where the flow direction was incorrectly tagged with the oneway key.

-these tags can no longer be automatically deleted by pushing the "fix" button in the validator?

yes the fix button is disabled in all these cases

comment:6 in reply to:  5 Changed 4 days ago by multimodaal <multimodaal@…>

Replying to Klumbumbus:

Perfect! thanks (-:

I also added to the wiki for Key:oneway
"Legal oneway restrictions for a mandatory direction of travel on waterways can be mapped with oneway= as well, for instance when signposted with a seamark or when this is part of legislation. For describing the direction of flow of water please consider different tags than this legal key oneway= "

https://wiki.openstreetmap.org/wiki/Key:oneway#On_waterways

comment:8 Changed 4 days ago by multimodaal <multimodaal@…>

thx, that's a good addition. I added a sentence for special cases with bi directional flow.
https://wiki.openstreetmap.org/w/index.php?title=Key%3Aoneway&type=revision&diff=2050138&oldid=2050137

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.