Extruder: Problem with common node extruding to the inside.

[skyper]

What steps will reproduce the problem?

1. Create a new way with two nodes
2. Change to extruder mode and create an rectangle area.
3. Create another connected rectangle area pressing Alt in extruder mode
4. Try to separate the two areas by extruding the common segment to the inner side of one area

What is the expected result?

Two separate ways without a common node

What happens instead?

One former corner node is not released and still part of both ways.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-11 23:10:16 +0200 (Sun, 11 Oct 2020)
Revision:17170
Build-Date:2020-10-12 01:30:50
URL:https://josm.openstreetmap.de/svn/trunk

[GerdP]

Regression of r17141.

[GerdP]

In 17183/josm:

fix #19924: Extruder: Problem with common node extruding to the inside.

• revert r17141
• use wNew.getNodes() to create ChangeNodesCommand

Stupid me! Methods Way.addNode() and Way.removeNode() cannot simply be replaced by List.add() or List.remove(). Results can differ.

[GerdP]

Lesson learned: Found the same error in DataSet.unlinkNodeFromWays(Node node) and wondered why nobody noticed it. Turned out that it is one possible reason for tickets with DataIntegrityProblemException: Deleted node referenced
Yippi!

[stoecker]

So making errors is not always bad. Congratulations!

[simon04]

Replying to GerdP:

Turned out that it is one possible reason for tickets with DataIntegrityProblemException: Deleted node referenced

Yay!

[skyper]

Replying to stoecker:

So making errors is not always bad. Congratulations!

+1

Nice, thanks for the fast fix.

[Don-vip]

Milestone renamed