numeric.mapcss regex and silent fail of fixAdd

[frodrigo]

The meter part
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/numeric.mapcss#L156
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/numeric.mapcss#L188
it is not done like the feet part
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/numeric.mapcss#L166
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/numeric.mapcss#L198

The regex meter ([0-9]*\.?[0-9]*) match event without any number ("m" what the regex) while the feet one ([0-9]+\.?[0-9]*) require at least a number.

If the rule matchs without number the following regex in the fixAdd does not have match. It looks like to me, JOSM silently fails on the fixAdd error.

I found this with the Osmose MapCSS implementation. On Osmose the fixAdd fails with an error.

[Klumbumbus]

In 17145/josm:

fix #19907 - Don't autofix width|maxwidth=metre|metres|meter|meters|Metre|Metres|Meter|Meters|m to width|maxwidth= metre| metres| meter| meters| Metre| Metres| Meter| Meters| m

[skyper]

maxheight and maxwidth could be adjusted as cases with leading zero are missed, atm.

In general we miss cases without leading numbers like .25meters, now. Think syntax need to be changed to e.g.:

*[width][width =~ /^([0-9]+\.?[0-9]*|\.[0-9]+)(( )*(metre|metres|meter|meters|Metre|Metres|Meter|Meters)|m)$/] {

[Famlam]

Perhaps also good to note - since they're now being adjusted - that the regexes in numeric.mapcss all consider "2. m" as valid. Not sure if that's supposed to happen.

[gaben]

Probably not, but it seems very edge case.

[Klumbumbus]

Replying to skyper:

In general we miss cases without leading numbers like .25meters, now.

This is catched by the rules without autofix.

[skyper]

Replying to Klumbumbus:

Replying to skyper:

In general we miss cases without leading numbers like .25meters, now.

This is catched by the rules without autofix.

Are there reasons to not allow to autofix this case?

[Klumbumbus]

In 17266/josm:

fix #19907 - Adjust some numeric regular expessions to warn about cases with missing numbers after decimal separator (width=10'2." or maxheight=2. m), don't warn about values without inch (feet only)

[Klumbumbus]

In 17267/josm:

see #19907 - Remove foot/inch from maxweight/maxaleload regular expressions

[Klumbumbus]

Replying to skyper:

Replying to Klumbumbus:

Replying to skyper:

In general we miss cases without leading numbers like .25meters, now.

This is catched by the rules without autofix.

Are there reasons to not allow to autofix this case?

After the "fixing" to .25 m the value is still wrong, which not so nice. A manual fix by the user is required here anyway.

Creating a separate rule which fixes both errors together is not needed as there are probably very few such cases.

[Klumbumbus]

In 17268/josm:

see #19907 - Avoid that the fix button of some numeric tests produces a still wrong value

[Don-vip]

Milestone renamed