TagChecker cannot cope with read-only datasets.

[GerdP]

What steps will reproduce the problem?

1. Load attached locked file with a way mistagged building=hous
2. Make sure that information level for validator is enabled
3. run validator

What is the expected result?

Unknown property value - Value 'hous' for key 'building' is unknown, maybe 'house' is meant? (1)

What happens instead?

Bug report

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2020-10-08 10:44:30
Revision:17110
Is-Local-Build:true

Identification: JOSM/1.5 (17110 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 1048 MB / 3641 MB (800 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:50188, -ea, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ PolygonCutOut (v0.7)
+ apache-commons (35524)
+ buildings_tools (35570)
+ continuosDownload (91)
+ ejml (35313)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ merge-overlap (35248)
+ o5m (35248)
+ opendata (35513)
+ pbf (35446)
+ poly (35248)
+ reverter (35556)
+ undelete (35521)
+ utilsplugin2 (35487)

Last errors/warnings:
- 00025.012 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive cannot be modified in read-only dataset: {Node id=-101754 version=0 MV lat=50.22809796267,lon=9.03944351146}


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (20) of main
org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive cannot be modified in read-only dataset: {Node id=-101754 version=0 MV lat=50.22809796267,lon=9.03944351146}
	at org.openstreetmap.josm.data.osm.OsmPrimitive.checkDatasetNotReadOnly(OsmPrimitive.java:208)
	at org.openstreetmap.josm.data.osm.OsmPrimitive.addReferrer(OsmPrimitive.java:702)
	at org.openstreetmap.josm.data.osm.Way.setNodes(Way.java:61)
	at org.openstreetmap.josm.data.osm.Way.cloneFrom(Way.java:302)
	at org.openstreetmap.josm.data.osm.Way.<init>(Way.java:206)
	at org.openstreetmap.josm.data.osm.Way.<init>(Way.java:220)
	at org.openstreetmap.josm.data.osm.Way.<init>(Way.java:229)
	at org.openstreetmap.josm.data.validation.tests.TagChecker.filterDeprecatedTags(TagChecker.java:979)
	at org.openstreetmap.josm.data.validation.tests.TagChecker.tryGuess(TagChecker.java:930)
	at org.openstreetmap.josm.data.validation.tests.TagChecker.checkSingleTagComplex(TagChecker.java:844)
	at org.openstreetmap.josm.data.validation.tests.TagChecker.check(TagChecker.java:626)
	at org.openstreetmap.josm.data.validation.Test$TagTest.visit(Test.java:134)
	at org.openstreetmap.josm.data.osm.Way.accept(Way.java:177)
	at org.openstreetmap.josm.data.validation.Test.visit(Test.java:216)
	at org.openstreetmap.josm.data.validation.tests.TagChecker.visit(TagChecker.java:1062)
	at org.openstreetmap.josm.actions.ValidateAction$ValidationTask.realRun(ValidateAction.java:169)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:94)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

[GerdP]

In 17113/josm:

fix #19895: TagChecker cannot cope with read-only datasets.
Use different method to create clones for special case where we test agains deprecated.mapcss rules

[Don-vip]

Milestone renamed