Modify

Opened 4 weeks ago

Closed 4 weeks ago

#19835 closed enhancement (fixed)

cuisine=bbq should be corrected to barbecue

Reported by: ferdi Owned by: team
Priority: normal Milestone: 20.09
Component: Core validator Version:
Keywords: Cc:

Description

the documented and de facto use is the long form

Attachments (0)

Change History (6)

comment:1 Changed 4 weeks ago by skyper

How does an automatic fix of a multi-value value work? Think this is not working, atm.

Last edited 4 weeks ago by skyper (previous) (diff)

comment:2 Changed 4 weeks ago by anonymous

Maybe just throw a warning if the cuisine tag contains bbq as a string Somewhere and ask people to manually replace that value ?

comment:3 in reply to:  2 Changed 4 weeks ago by skyper

Replying to anonymous:

Maybe just throw a warning if the cuisine tag contains bbq as a string Somewhere and ask people to manually replace that value ?

Sure, a simple warning can always be thrown and a auto-fix with only bbq as value should not be a problem.

comment:4 Changed 4 weeks ago by Klumbumbus

Milestone: 20.09
Priority: minornormal

comment:5 in reply to:  1 Changed 4 weeks ago by Klumbumbus

Replying to skyper:

How does an automatic fix of a multi-value value work? Think this is not working, atm.

This basically works:

*[cuisine *= bbq] {
  throwWarning: tr("{0} is deprecated", "cuisine=bbq");
  suggestAlternative: "cuisine=barbecue";
  group: tr("deprecated tagging");
  fixAdd: concat("cuisine=", replace(tag("cuisine"), "bbq", "barbecue"))
}

However in this case there is not only "bbq" as substring of the cuisine value but we have to care also about "BBQ" and cases like "korean_bbq". taginfo (type "bbq" in the values filter box) We should not replace "korean_bbq" by "korean_barbecue".

In the end it would be too complex to make the rules work with autofix for all possible combinations. I'll go with your comment:3.

comment:6 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17048/josm:

fix #19835 - Deprecate cuisine=bbq (case insensitive) in favor of cuisine=barbecue

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.