cuisine=bbq should be corrected to barbecue

[ferdi]

the documented and de facto use is the long form

[skyper]

How does an automatic fix of a multi-value value work? Think this is not working, atm.

[anonymous]

Maybe just throw a warning if the cuisine tag contains bbq as a string Somewhere and ask people to manually replace that value ?

[skyper]

Replying to anonymous:

Maybe just throw a warning if the cuisine tag contains bbq as a string Somewhere and ask people to manually replace that value ?

Sure, a simple warning can always be thrown and a auto-fix with only bbq as value should not be a problem.

[Klumbumbus]

Replying to skyper:

How does an automatic fix of a multi-value value work? Think this is not working, atm.

This basically works:

*[cuisine *= bbq] {
  throwWarning: tr("{0} is deprecated", "cuisine=bbq");
  suggestAlternative: "cuisine=barbecue";
  group: tr("deprecated tagging");
  fixAdd: concat("cuisine=", replace(tag("cuisine"), "bbq", "barbecue"))
}

However in this case there is not only "bbq" as substring of the cuisine value but we have to care also about "BBQ" and cases like "korean_bbq". ​taginfo (type "bbq" in the values filter box) We should not replace "korean_bbq" by "korean_barbecue".

In the end it would be too complex to make the rules work with autofix for all possible combinations. I'll go with your comment:3.

[Klumbumbus]

In 17048/josm:

fix #19835 - Deprecate cuisine=bbq (case insensitive) in favor of cuisine=barbecue