Modify

Opened 3 weeks ago

Closed 3 weeks ago

Last modified 2 weeks ago

#19720 closed defect (fixed)

lift_gate:type dropdown list is empty

Reported by: gaben Owned by: team
Priority: minor Milestone: 20.08
Component: Internal preset Version: latest
Keywords: Cc: stoecker

Description (last modified by skyper)

See the attached picture.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-08-25 23:27:27 +0200 (Tue, 25 Aug 2020)
Build-Date:2020-08-26 01:30:48
Revision:16932
Relative:URL: ^/trunk

Attachments (1)

empty_dropdown.png (25.8 KB) - added by gaben 3 weeks ago.

Download all attachments as: .zip

Change History (12)

Changed 3 weeks ago by gaben

Attachment: empty_dropdown.png added

comment:1 Changed 3 weeks ago by gaben

Description: modified (diff)

comment:2 Changed 3 weeks ago by skyper

Description: modified (diff)

There is a s missing for values

@@ -1687,7 +1687,7 @@
             <link wiki="Tag:barrier=lift_gate" />
             <key key="barrier" value="lift_gate" />
             <space />
-            <combo key="lift_gate:type" text="Type" value="single,double" values_context="lift_gate" values_searchable="true" />
+            <combo key="lift_gate:type" text="Type" values="single,double" values_context="lift_gate" values_searchable="true" />
             <reference ref="optional_maxwidth" />
             <combo key="material" text="Material" values="concrete,metal,plastic,stone,wood" />
             <space />

comment:3 Changed 3 weeks ago by skyper

This should have been reported by Jenkins.

comment:4 in reply to:  3 Changed 3 weeks ago by gaben

Combo key shouldn't have value only values attribute?

If I investigated correctly, it is checked here https://josm.openstreetmap.de/browser/josm/trunk/resources/data/tagging-preset.xsd#L397

Edit: Unfortunately, this is a different thing :) I'm not familiar with XSD.

Last edited 3 weeks ago by gaben (previous) (diff)

comment:5 Changed 3 weeks ago by Klumbumbus

Milestone: 20.08

it's from r16801

comment:6 Changed 3 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16943/josm:

fix #19720 - Fix lift_gate:type dropdown list

comment:7 in reply to:  6 ; Changed 3 weeks ago by skyper

Cc: stoecker added

Replying to Klumbumbus:

In 16943/josm:

fix #19720 - Fix lift_gate:type dropdown list

Thanks, but why did Jenkins not report the common typo?

Was the test disabled? Does it not work properly?

comment:8 in reply to:  7 ; Changed 3 weeks ago by gaben

Replying to skyper:

Was the test disabled?

Where is the test file?

comment:9 in reply to:  8 Changed 3 weeks ago by skyper

Replying to gaben:

Replying to skyper:

Was the test disabled?

Where is the test file?

Sorry, seems like I mix dreams and reality.

Probably, worth an own ticket.

Last edited 2 weeks ago by skyper (previous) (diff)

comment:10 Changed 2 weeks ago by gaben

I'm currently experimenting with an XSD patch to prevent similar issues in the future. It works for me but at the beginning of the tagging-preset.xsd, someone put a little warning about the <anyAttribute/> tag. See it here: https://josm.openstreetmap.de/browser/josm/trunk/resources/data/tagging-preset.xsd#L6
Do you know any usage the defaultpresets.xml and tagging-preset.xsd outside of JOSM (eg. Vespucci)?

Just removed the <anyAttribute processContents="skip" /> rows from the XSD and fixed the errors in the XML. I don't know if it's safe or not, because JOSM doesn't care much about these lines :/

comment:11 Changed 2 weeks ago by stoecker

As the comment says that wont work for at least two reasons:

  • I18n gets impossible
  • Adding new tags gets impossible in external presets

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.