lift_gate:type dropdown list is empty

[gaben]

See the attached picture.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-08-25 23:27:27 +0200 (Tue, 25 Aug 2020)
Build-Date:2020-08-26 01:30:48
Revision:16932
Relative:URL: ^/trunk

[skyper]

There is a s missing for values

@@ -1687,7 +1687,7 @@
             <link wiki="Tag:barrier=lift_gate" />
             <key key="barrier" value="lift_gate" />
             <space />
-            <combo key="lift_gate:type" text="Type" value="single,double" values_context="lift_gate" values_searchable="true" />
+            <combo key="lift_gate:type" text="Type" values="single,double" values_context="lift_gate" values_searchable="true" />
             <reference ref="optional_maxwidth" />
             <combo key="material" text="Material" values="concrete,metal,plastic,stone,wood" />
             <space />

[skyper]

This should have been reported by Jenkins.

[gaben]

Combo key shouldn't have value only values attribute?

If I investigated correctly, it is checked here https://josm.openstreetmap.de/browser/josm/trunk/resources/data/tagging-preset.xsd#L397

Edit: Unfortunately, this is a different thing :) I'm not familiar with XSD.

[Klumbumbus]

it's from r16801

[Klumbumbus]

In 16943/josm:

fix #19720 - Fix lift_gate:type dropdown list

[skyper]

Replying to Klumbumbus:

In 16943/josm:

fix #19720 - Fix lift_gate:type dropdown list

Thanks, but why did Jenkins not report the common typo?

Was the test disabled? Does it not work properly?

[gaben]

Replying to skyper:

Was the test disabled?

Where is the test file?

[skyper]

Replying to gaben:

Replying to skyper:

Was the test disabled?

Where is the test file?

Sorry, seems like I mix dreams and reality.

Probably, worth an own ticket.

[gaben]

I'm currently experimenting with an XSD patch to prevent similar issues in the future. It works for me but at the beginning of the tagging-preset.xsd, someone put a little warning about the <anyAttribute/> tag. See it here: https://josm.openstreetmap.de/browser/josm/trunk/resources/data/tagging-preset.xsd#L6
Do you know any usage the defaultpresets.xml and tagging-preset.xsd outside of JOSM (eg. Vespucci)?

Just removed the <anyAttribute processContents="skip" /> rows from the XSD and fixed the errors in the XML. I don't know if it's safe or not, because JOSM doesn't care much about these lines :/

[stoecker]

As the comment says that wont work for at least two reasons:

• I18n gets impossible
• Adding new tags gets impossible in external presets