Modify ↓

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#19704 closed enhancement (fixed)

[Patch] DateUtils: sychronization is no longer needed thanks to JSR 310

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.11
Component: Core Version:
Keywords: java8 jsr310 performance timestamp Cc: Don-vip, taylor.smock

Description

Thanks to JSR 310, ​JEP 150 and #13376, almost everything in DateUtils is thread-safe. So we can drop the synchronized function modifiers.

Would someone please review the attached patch? Thanks!

Doing 800k tests in parallel (n=64) did not reveal any bugs and received a nice speed-up (13.992s → 2.213s).

Attachments (1)

19704.patch​ (5.9 KB ) - added by simon04 5 years ago.

Download all attachments as: .zip

Change History (5)

by simon04, 5 years ago

Attachment: 19704.patch​ added

comment:1 by Don-vip, 5 years ago

Milestone: 20.09 → 20.10

comment:2 by simon04, 5 years ago

Resolution: → fixed
Status: assigned → closed

In 17104/josm:

fix #19704 - DateUtils: sychronization is no longer needed thanks to JSR 310

comment:3 by simon04, 5 years ago

In 17114/josm:

see #19704 - Enhance DateUtils.tsFromString to fix unit tests

comment:4 by Don-vip, 5 years ago

Milestone: 20.10 → 20.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.