prevent or discourage download of blocked data into non-blocked layer

[augustin.roche@…]

Hi, I use the French cadastre plugin to update missing buildings with that workflow :

• download osm data on the area
• download cadastre buildings in a new layer
• pick missing building from cadastre layer and copy them into main layer.

But sometimes, instead of clicking on "download into a new layer", I mistakenly click on "download" and then, as the cadastre data is tagged with "upload=never", the main layer becomes impossible to upload.

The only workaround I found is to save the layer as .osm file, open it in a text editor, remove the "upload=never" tag and re-open the layer in JOSM.

I think that the import of locked data into a non-locked layer should be prohibited or at least discouraged with a message box and the ability to cancel.

What steps will reproduce the problem?

1. download OSM data on an area
2. using the French cadastre plugin or any other data source that will allow download of blocked data (with "upload=never"), upload data into the same layer.

What is the expected result?

a message box should pop with a message warning that the layer will be impossible to upload and the ability to cancel

What happens instead?

the locked data is downloaded without a warning into the current layer.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-30 12:44:04 +0200 (Thu, 30 Jul 2020)
Build-Date:2020-07-31 01:30:49
Revision:16812
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16812 fr) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1809 (17763)
Memory Usage: 2571 MB / 7244 MB (323 MB allocated, but free)
Java version: 1.8.0_161-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0), \Display1 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.23)
+ SimplifyArea (35405)
+ apache-commons (35362)
+ apache-http (35092)
+ cadastre-fr (35405)
+ ejml (35313)
+ geotools (35169)
+ javafx-windows (35458)
+ jna (35092)
+ jts (35122)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ utilsplugin2 (35487)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Windrad&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1

Last errors/warnings:
- W: Mettre à jour - Vous avez mis à jour votre logiciel JOSM. Les greffons devraient aussi être mis à jour pour éviter les conflits. Voulez-vous les mettre à jour maintenant ?
- W: JOSM devrait trouver lʼobjet [nœud -110107] dans le jeu de données, mais il nʼest pas là. Merci de le signaler à https://josm.openstreetmap.de. Ce nʼest pas une erreur critique, il ne devrait pas y avoir de problème pour continuer votre travail.
- E: java.lang.Exception
- W: java.net.UnknownHostException: api.openstreetmap.org
- E: java.net.UnknownHostException: api.openstreetmap.org
- W: org.openstreetmap.josm.io.OsmTransferException: Impossible de joindre le serveur. Veuillez vérifier votre connexion Internet.. Cause : java.net.UnknownHostException: api.openstreetmap.org