Modify

Opened 2 years ago

Closed 22 months ago

#19603 closed enhancement (fixed)

[Patch] footway=* instead of sidewalk=* on roads

Reported by: Famlam Owned by: team
Priority: normal Milestone: 20.09
Component: Core validator Version:
Keywords: footway sidewalk Cc: Klumbumbus

Description (last modified by Famlam)

The key footway is quite often incorrectly used when (in most cases, most likely) sidewalk=* is meant.

Perhaps it is an idea to make the validator complain about "disallowed" highway values combined with footway=*? (Formally it's allowed on highway=footway/path/construction only, although it seems quite a common tag to use on highway=cycleway too)
overpass-turbo for the area around The Netherlands

If not, then it might be worth adding a check for footway=* without highway=* tag (or prefixed highway keys)? Overpass-turbo

/* 19603 */
way[footway][highway][footway=sidewalk][highway!=footway][highway!=path][highway!=construction][highway!=cycleway] {
  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
  group: tr("suspicious tag combination");
  suggestAlternative: "sidewalk=left";
  suggestAlternative: "sidewalk=right";
  suggestAlternative: "sidewalk=both";
}
/* 19603 */
way[footway][highway][footway!=sidewalk][highway!=footway][highway!=path][highway!=construction][highway!=cycleway] {
  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
  group: tr("suspicious tag combination");
}

/* 19603 */
way[footway][!highway][!/:highway$/],
way[cycleway][!highway][!/:highway$/] {
  throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
  set MissingKeyWarning;
  group: tr("missing tag");
}

Attachments (0)

Change History (10)

comment:1 Changed 2 years ago by Famlam

Description: modified (diff)

comment:2 Changed 2 years ago by Famlam

Description: modified (diff)

comment:3 Changed 2 years ago by skyper

I use path=sidewalk. One reason that cycleway=sidewalk is not used is the validator warning about it.

Nowadays, with *=use_sidepath the proper tag for all three might be side_path=yes instead of *=sidewalk but that needs discussion.

comment:4 Changed 2 years ago by anonymous

@skyper, I didn't fully understand your reply (side_path?), but to clarify: this patch doesn't modify tags on i.e. highway=path/cycleway/footway.

It just adds a warning on i.e. highway=residential + footway=sidewalk.
Here the correct way to map it would be sidewalk=*

Last edited 2 years ago by Famlam (previous) (diff)

comment:5 in reply to:  description Changed 2 years ago by skyper

Replying to anonymous:

@skyper, I didn't fully understand your reply (side_path?)

Sorry, should have quoted:

Replying to Famlam:

Perhaps it is an idea to make the validator complain about "disallowed" highway values combined with footway=*? (Formally it's allowed on highway=footway/path/construction only, although it seems quite a common tag to use on highway=cycleway too)

What I think is that instead of footway=sidewalk or cycleway=sidewalk a new tag sidepath=yes would fit to highway=cycleway/footway/path and bicycle/foot=use_sidepath. We would not need footway=sidewalk on cycleways or three different tags cycleway/footway/path=sidewalk.

but to clarify: this patch doesn't modify tags on i.e. highway=path/cycleway/footway.
It just adds a warning on i.e. highway=residential + footway=sidewalk.
Here the correct way to map it would be sidewalk=*

Yes, sure, did not want to criticize your suggestions.

comment:6 Changed 2 years ago by skyper

Priority: minornormal
Summary: footway=* instead of sidewalk=* on roads[Patch] footway=* instead of sidewalk=* on roads

comment:7 Changed 23 months ago by simon04

Cc: Klumbumbus added
Milestone: 20.08

comment:8 Changed 23 months ago by Klumbumbus

It was already on my todo list.

comment:9 Changed 22 months ago by Klumbumbus

Milestone: 20.0820.09

comment:10 Changed 22 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17051/josm:

fix #19603 - Warn about suspicious tag combinations with footway=* (based on patch by Famlam)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.