[PATCH] Preferences enableSaveOnPut/disableSaveOnPut

[hiddewie]

In the Preferences class there is a method enableSaveOnPut that enables or disables save on put operations.

However, all method calls have the argument false. Furthermore, having a single boolean argument to enable/disable something is a code smell.

The patch creates two specialized methods and deprecates the old method.

[simon04]

This affects the following plugins:

• ​https://github.com/JOSM/conflation/blob/master/test/unit/org/openstreetmap/josm/plugins/conflation/ConflationPluginTest.java
• ​https://gitlab.com/JOSM/plugin/contourmerge/blob/master/src/test/groovy/org/openstreetmap/josm/plugins/contourmerge/fixtures/JOSMFixture.java
• ​https://gitlab.com/JOSM/plugin/pt_assistant/blob/master/test/unit/org/openstreetmap/josm/plugins/pt_assistant/TestUtil.java
• ​https://gitlab.com/JOSM/plugin/scripting/blob/master/test/common/org/openstreetmap/josm/plugins/scripting/fixtures/JOSMFixture.java

[simon04]

Thanks for the patch. I agree that the code gets clearer. However, for me, the effort for taking care of the deprecation and updating the plugins does not justify the change.