Opened 4 years ago

Last modified 4 years ago

#19436 closed defect

[PATCH] Don't attempt to add null objects to a JsonArray in RequestProcessor — at Version 1

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 20.07
Component: Core remotecontrol Version:
Keywords: Cc: simon04

Description (last modified by taylor.smock)

For some reason, on some configurations, my plugin isn't registering itself properly, which causes an NPE in RequestProcessor#getHandlersInfoAsJson. This is due to the code returning a null value (on purpose), and then attempting to add the null value to the JsonArray builder.

This is a regression from r16550. StringBuilder happily accepted null values and output null in the string.

I'm attaching a partial preferences xml so I can fix it in MapWithAI as well (I shouldn't be allowing 8111 ports in mapwithai.sources.entries right now).

  <tag key='remotecontrol.enabled' value='true'/>
  <tag key='remotecontrol.new-layer' value='true'/>
  <maps key='mapwithai.sources.entries'>
    <map>
      <tag key='parameters' value='[]'/>
      <tag key='name' value='a'/>
      <tag key='type' value='thirdParty'/>
      <tag key='url' value='http://localhost:8111/features?q=mapwithai'/>
      <tag key='cookies' value=''/>
      <tag key='customHttpHeaders' value='{}'/>
      <tag key='category' value='other'/>
    </map>

Change History (2)

by taylor.smock, 4 years ago

Attachment: 19436.patch added

comment:1 by taylor.smock, 4 years ago

Cc: simon04 added
Description: modified (diff)
Note: See TracTickets for help on using tickets.