Unglue ways: Remaining node with tags moved

[skyper]

What steps will reproduce the problem?

1. Have an unconnected way with two node with one node with tags
2. Select the end node with tags
3. Unglue ways

What is the expected result?

The way is unglued and a new node is added at the same position as the selected node. The selected node remains unchanged.

What happens instead?

Unglue works but the selected node is moved similar to "extract node" from utilsplugin2

Please provide any additional information below. Attach a screenshot if possible.

Seems to be a regression of the better handling of tags and memberships.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-06-03 21:59:58 +0200 (Wed, 03 Jun 2020)
Revision:16540
Build-Date:2020-06-04 01:30:48
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

It does also happen with middle nodes and is a regression of r16300. Before unglueing a node with only one parent was not possible.

[GerdP]

I just tried r16102 and the node is unglued. What exactly is the regression?

[skyper]

The position of the node with positive id is moved but it should not. Before, you needed "Disconnect Node from Way" which only changes the way but keeps the node untouched.

[GerdP]

So, you suggest that the new node is moved instead? That would change the geometry of the way. I am sure this did not happen before. Or should both nodes be at the same place no matter where the cursor is?

[skyper]

Replying to GerdP:

So, you suggest that the new node is moved instead? That would change the geometry of the way. I am sure this did not happen before. Or should both nodes be at the same place no matter where the cursor is?

Before, you got a notification and unglueing was denied, which is the same behavior as with nodes without membership nor tag. Now, to be consistent, I would say, both nodes should be at the same place, all the time.

[GerdP]

What version do you mean with before? Are we both talking about the action with shortcut G?

[skyper]

I am completely sorry. I can swore that I had a notification, The node is not glued to anything else, with a tagged node with r16294 but now I cannot reproduce it. Maybe, it is time for some glasses or new hardware.

[GerdP]

OK, so we are only discussing wether or not the node should be moved. See also r16362.
My understanding was that one wants to unglue the tagged node because it was never meant to be at the position where it is, e.g. because it snapped to the way. If you don't want to change the position of the node Alt+J (Disconnect Node from Way) could be an alternative.

[skyper]

I know and use "Disconnect Node from Way" but what is the difference between "Unglue" and "Extract nodes" Alt+Shift+J from utilsplugin2?

[GerdP]

Looking at the code I's say: Extract nodes creates a single new node and replaces the first occurence of the selected node with this new node in every refering way. Unglue may create multiple new nodes. When the node is only referrenced by one way there seems to be no difference.

[skyper]

So, I would suggest to be consistent and let "Extract nodes" move the node and have unglue keep the position but as it is no regression I do not want to upset users in changing the behavior, so maybe, this is even a wontfix.

[GerdP]

I prefer wontfix.