Opened 6 years ago

Last modified 5 years ago

#19257 closed enhancement

reduce number of ShowHistoryAction implementations — at Version 1

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.05
Component: Core Version:
Keywords: history Cc:

Description (last modified by GerdP)

follow up of #19254
We have multiple implementations of a class ShowHistoryAction
org.openstreetmap.josm.gui.dialogs.changeset.ChangesetContentPanel.ShowHistoryAction
org.openstreetmap.josm.gui.dialogs.SelectionListDialog.ShowHistoryAction
org.openstreetmap.josm.gui.history.ShowHistoryAction
They look very similar. We should have one implementation which can handle a collection of ids.
There is also org.openstreetmap.josm.actions.HistoryInfoAction which reacts on Ctrl+H.
At least they should all use HistoryBrowserDialogManager to do the real work of downloading data.

Change History (1)

comment:1 by GerdP, 6 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.