Java 8: use Stream

[simon04]

In 16436/josm:

see #19251 - Java 8: use Stream

[simon04]

In 16437/josm:

see #19251 - Fix MapListSetting

[simon04]

In 16438/josm:

see #19251 - Java 8: use Stream

[GerdP]

Are you sure that this doesn't cause an endless loop when relation contains itself or when we have more complex loops like
a -> b, b-> c; c->a ?

        nearestList.stream()
                .flatMap(o -> o.getReferrers().stream())
                .filter(r -> r instanceof Relation && predicate.test(r))
                .forEach(nearestList::add);

NavigatableComponent line 1610ff

[GerdP]

see #19252, probably a regression

[simon04]

In 16441/josm:

see #19251 - Checkstyle, PMD

[simon04]

In 16444/josm:

see #19251 - Fix NavigatableComponent.getAllNearest

[simon04]

In 16445/josm:

see #19251 - Java 8: use Stream

[simon04]

Replying to GerdP:

Are you sure that this doesn't cause an endless loop when relation contains itself or when we have more complex loops like
a -> b, b-> c; c->a ?

No, thanks for spotting the error! Inlining the variable parentRelations was faulty. I addressed this in r16444.

Edit: This error also has been reported by Java: https://josm.openstreetmap.de/jenkins/job/JOSM/6422/warnings9Result/module.1732282867/package.-515814635/

[GerdP]

Yes, that's why I looked at it ;)

[simon04]

And I thought you were studiously reading through the lengthy diff. ;-)

[simon04]

In 16448/josm:

see #19251 - Java warnings

[simon04]

In 16451/josm:

see #19251 - Java warning, FindBugs

[simon04]

In 16452/josm:

see #19251 - Java 8: use Stream

[simon04]

In 16453/josm:

see #19251, see #19252 - fix findFirst/map/orElse sequence

[GerdP]

see #19259 for a regression

[GerdP]

see #19055 for a regression