Opened 5 years ago

Last modified 4 years ago

#19180 closed enhancement

false positives from tagchecker with single letter differences — at Version 4

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.07
Component: Core validator Version:
Keywords: tagchecker single letter Cc: Klumbumbus

Description (last modified by Klumbumbus)

Follow up for #17055

I've done the steps described in ticket:17055#comment:55 again on updated taginfo data to get this list:

Value 'y' for key 'x' is unknown, maybe 'z' is meant?

tag know value tagcount decision
access=customercustomers1024|102|910|12
addr:inclusion=estimatedestimate1301|0|1301|0
building=apartmentapartments2368|84|2284|0
building=constructieconstruction3949|0|3949|0
building=homehotel, house1462|706|756|0
building=partbarn, farm1192|322|828|42
building=ruinruins1680|8|1672|0
building=tankbank|2902|11|2890|1
building=yes,yes2136|0|2136|0
generator:type=solar_photovoltaic_panelssolar_photovoltaic_panel6702|8|6679|15
historic=farmfort2125|316|1632|177
lamp_mount=bent mastbent_mast10347|10334|13|0
lamp_mount=straight maststraight_mast13124|13108|16|0
lamp_type=electricalelectric3678|3678|0|0
lanes=-111820|0|1820|0
man_made=water_tankwater_tap4243|2433|1807|3
resource=claycoal1111|2|1088|21
sport=skiingskating5857|1157|4502|198
toilets:disposal=pit_latrinepitlatrine3993|3993|0|0
water=poolpond2609|0|2583|26

I think these tags should be treated in presets or ignoretags.cfg:
historic=farm
resource=clay
sport=skiing

Maybe add a mapcss check for these which proposes a different tag?
building=part -> building:part=yes
building=tank -> man_made=storage_tank or water_tank or ?
water=pool -> amenity=swimming_pool

The building='yes,' objects are from hotosm projects, I've commented some CS.

Change History (4)

comment:1 by GerdP, 5 years ago

Cc: Klumbumbus added
Component: CoreCore validator

comment:2 by skyper, 5 years ago

Keywords: tagchecker single letter added
Summary: false positives from Validatorfalse positives from tagchecker with single letter differences

comment:3 by Klumbumbus, 5 years ago

Milestone: 20.07

comment:4 by Klumbumbus, 5 years ago

Description: modified (diff)

(convert into table)

Note: See TracTickets for help on using tickets.