false positives from tagchecker with single letter differences

[GerdP]

Follow up for #17055

I've done the steps described in ticket:17055#comment:55 again on updated taginfo data to get this list:

Value 'y' for key 'x' is unknown, maybe 'z' is meant?

tag	know value	tagcount	decision
access=customer	customers	1024|102|910|12	✔️ added to deprecated.mapcss and ignorelist
addr:inclusion=estimated	estimate	1301|0|1301|0	✔️ added to deprecated.mapcss and ignorelist
building=apartment	apartments	2368|84|2284|0	✔️ added to deprecated.mapcss and ignorelist
building=constructie	construction	3949|0|3949|0	​overpass turbo
building=home	hotel, house	1462|706|756|0
building=part	barn, farm	1192|322|828|42
building=ruin	ruins	1680|8|1672|0
building=tank	bank	2902|11|2890|1
building=yes,	yes	2136|0|2136|0	✔️ only in two villages, fixed in the osm database
generator:type=solar_photovoltaic_panels	solar_photovoltaic_panel	6702|8|6679|15
historic=farm	fort	2125|316|1632|177
lamp_mount=bent mast	bent_mast	10347|10334|13|0	✔️ added to deprecated.mapcss and ignorelist
lamp_mount=straight mast	straight_mast	13124|13108|16|0	✔️ added to deprecated.mapcss and ignorelist
lamp_type=electrical	electric	3678|3678|0|0	✔️ added to deprecated.mapcss and ignorelist
lanes=-1	1	1820|0|1820|0	✔️ already in numerical.mapcss, added to ignorelist
man_made=water_tank	water_tap	4243|2433|1807|3	✔️ already in deprecated.mapcss, added to ignorelist
resource=clay	coal	1111|2|1088|21
sport=skiing	skating	5857|1157|4502|198	✔️ already in deprecated.mapcss, added to ignorelist
toilets:disposal=pit_latrine	pitlatrine	3993|3993|0|0	✔️ was already fixed in the osm database (​taghistory)
water=pool	pond	2609|0|2583|26

I think these tags should be treated in presets or ignoretags.cfg:
historic=farm
resource=clay
sport=skiing

Maybe add a mapcss check for these which proposes a different tag?
building=part -> building:part=yes
building=tank -> man_made=storage_tank or water_tank or ?
water=pool -> amenity=swimming_pool

The building='yes,' objects are from hotosm projects, I've commented some CS.

[Klumbumbus]

(convert into table)

[Klumbumbus]

(accidently commited 3 rules in r16752)

[Klumbumbus]

Hm, I thought if a tag has an explizit deprecation warning in deprecated.mapcss then it would be removed from the "Value 'y' for key 'x' is unknown, maybe 'z' is meant" warning, but it is not, so we need to add it to the ignore list too.

[GerdP]

Replying to Klumbumbus:

Hm, I thought if a tag has an explizit deprecation warning in deprecated.mapcss then it would be removed from the "Value 'y' for key 'x' is unknown, maybe 'z' is meant" warning

I think the validator rules in *.mapcss are ignored. No idea if it would be possible to use them, at least it would require new code.
TagChecker learns from presets, words.cfg and ignoretags.cfg. So if it suggest a deprecated value these sources should be checked.

[Klumbumbus]

I always thought if a deprecation warning exists it was automatically removed from the "Value y for key x not in presets" info-warning, but it seems I'm wrong here too. Well it is a very minor problem, only duplicate warnings in severity warning and other.

[Klumbumbus]

In 16760/josm:

see #19180 - deprecate access=customer, addr:inclusion=estimated, building=apartment, lamp_mount="bent mast", lamp_mount="straight mast", lamp_type=electrical (common typos) and add some tags to ignore list

[Klumbumbus]

In 16762/josm:

see #19180 - Add most tags from deprecated.mapcss to ignorelist to clean up a bit the severity other group of validator results