Opened 6 years ago

Last modified 5 years ago

#19180 closed enhancement

false positives from Validator — at Initial Version

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.07
Component: Core validator Version:
Keywords: tagchecker single letter Cc: Klumbumbus

Description

Follow up for #17055

I've done the steps described in ticket:17055#comment:55 again on updated taginfo data to get this list:

false positive? access=customer Value 'customer' for key 'access' is unknown, maybe 'customers' is meant? access|customer|1024|102|910|12
false positive? addr:inclusion=estimated Value 'estimated' for key 'addr:inclusion' is unknown, maybe 'estimate' is meant? addr:inclusion|estimated|1301|0|1301|0
false positive? building=apartment Value 'apartment' for key 'building' is unknown, maybe 'apartments' is meant? building|apartment|2368|84|2284|0
false positive? building=constructie Value 'constructie' for key 'building' is unknown, maybe 'construction' is meant? building|constructie|3949|0|3949|0
false positive? building=home Value 'home' for key 'building' is unknown, maybe one of [hotel, house] is meant? building|home|1462|706|756|0
false positive? building=part Value 'part' for key 'building' is unknown, maybe one of [barn, farm] is meant? building|part|1192|322|828|42
false positive? building=ruin Value 'ruin' for key 'building' is unknown, maybe 'ruins' is meant? building|ruin|1680|8|1672|0
false positive? building=tank Value 'tank' for key 'building' is unknown, maybe 'bank' is meant? building|tank|2902|11|2890|1
false positive? building=yes, Value 'yes,' for key 'building' is unknown, maybe 'yes' is meant? building|yes,|2136|0|2136|0
false positive? generator:type=solar_photovoltaic_panels Value 'solar_photovoltaic_panels' for key 'generator:type' is unknown, maybe 'solar_photovoltaic_panel' is meant? generator:type|solar_photovoltaic_panels|6702|8|6679|15
false positive? historic=farm Value 'farm' for key 'historic' is unknown, maybe 'fort' is meant? historic|farm|2125|316|1632|177
false positive? lamp_mount=bent mast Value 'bent mast' for key 'lamp_mount' is unknown, maybe 'bent_mast' is meant? lamp_mount|bent mast|10347|10334|13|0
false positive? lamp_mount=straight mast Value 'straight mast' for key 'lamp_mount' is unknown, maybe 'straight_mast' is meant? lamp_mount|straight mast|13124|13108|16|0
false positive? lamp_type=electrical Value 'electrical' for key 'lamp_type' is unknown, maybe 'electric' is meant? lamp_type|electrical|3678|3678|0|0
false positive? lanes=-1 Value '-1' for key 'lanes' is unknown, maybe '1' is meant? lanes|-1|1820|0|1820|0
false positive? man_made=water_tank Value 'water_tank' for key 'man_made' is unknown, maybe 'water_tap' is meant? man_made|water_tank|4243|2433|1807|3
false positive? resource=clay Value 'clay' for key 'resource' is unknown, maybe 'coal' is meant? resource|clay|1111|2|1088|21
false positive? sport=skiing Value 'skiing' for key 'sport' is unknown, maybe 'skating' is meant? sport|skiing|5857|1157|4502|198
false positive? toilets:disposal=pit_latrine Value 'pit_latrine' for key 'toilets:disposal' is unknown, maybe 'pitlatrine' is meant? toilets:disposal|pit_latrine|3993|3993|0|0
false positive? water=pool Value 'pool' for key 'water' is unknown, maybe 'pond' is meant? water|pool|2609|0|2583|26

I think these tags should be treated in presets or ignoretags.cfg:
historic=farm
resource=clay
sport=skiing

Maybe add a mapcss check for these which proposes a different tag?
building=part -> building:part=yes
building=tank -> man_made=storage_tank or water_tank or ?
water=pool -> amenity=swimming_pool

The building='yes,' objects are from hotosm projects, I've commented some CS.

Change History (0)

Note: See TracTickets for help on using tickets.