Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#19171 closed defect (needinfo)

Validator: "water area inside water area" warning erroneous when natural=water inside natural=wetland

Reported by: liotier Owned by: team
Priority: minor Milestone:
Component: Core validator Version: latest
Keywords: Cc:

Description

A water body inside a wetland is normal. Therefore, the JOSM validator must not warn "water area inside water area" when natural=water is inside natural=wetland.

Attachments (1)

josm_19171_example.osm (7.7 KB ) - added by skyper 6 years ago.
example file

Download all attachments as: .zip

Change History (11)

comment:1 by mdk, 6 years ago

If you map this way, the inner area has natural=water and natural=wetland at the same time. Mapnik renders smaller areas above larger, but it is not correct mapping, if the inner area is wetland AND water.

If you want that the inner part is only natural=water, you have to create a multipolygon with the natural=wetland as "outer" and natural=water as "inner" role.

comment:2 by mdk, 6 years ago

Otherwise take a look at #9534.

comment:3 by liotier, 6 years ago

If you map this way, the inner area has natural=water and natural=wetland at the same time

That is correct - or rather the way I see it: wetlands are complex objects - water bodies are part of them, cross them or partially overlap them.

in reply to:  1 comment:4 by skyper, 6 years ago

Replying to mdk:

If you map this way, the inner area has natural=water and natural=wetland at the same time. Mapnik renders smaller areas above larger, but it is not correct mapping, if the inner area is wetland AND water.

What is correct? natural=water;wetland

comment:5 by skyper, 6 years ago

In fact, we do not have a proper solution, yet. Mapping the wetland as MP with only the outer polygon is simply a cheat and reminds me about #19148.

comment:6 by liotier, 6 years ago

I may be misunderstanding how to map that properly. Let me go to tagging@osm to confer - I'll come back with the consensus.

comment:7 by mdk, 6 years ago

And as discussed in #9534 overlapping of natural=water and natural=wetland could be clarified!

comment:8 by liotier, 6 years ago

The discussion at https://lists.openstreetmap.org/pipermail/tagging/2020-April/052280.html did not clarify whether overlap and full superposition have legit use-cases, but no one seems to disagree with multipolygons as the way to record any of such cases. So, the discussion will go on there, but this ticket car be closed. Thanks for your attention !

comment:9 by Klumbumbus, 6 years ago

Resolution: needinfo
Status: newclosed

by skyper, 6 years ago

Attachment: josm_19171_example.osm added

example file

comment:10 by skyper, 6 years ago

Well, I will use multipolygons for all areas as there is no warning, but for me it is the same as all other examples.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.