Modify

Opened 2 months ago

Closed 4 weeks ago

#19169 closed enhancement (fixed)

[PATCH] Modify JavaFxWrapper to better report initialization errors

Reported by: taylor.smock Owned by: Don-vip
Priority: normal Milestone:
Component: Plugin javafx Version:
Keywords: Cc:

Description

#19044 is getting hit more, and it would be nice to be able to detect the error and fall back to some other behavior (as well as getting a better stack trace).

The patch was originally added to #19114 as a possible method to get a better stack trace, and has been modified to also help plugins fall back to something else instead of crashing (by possibly throwing an exception during initialization).

The better stack trace comes from submitting a FutureTask to the JavaFx Platform.runLater and then performing a get on the FutureTask. This should not cause a block in the threads, since the class should not be instantiated inside of the JavaFx Platform thread.

In order to avoid having a bug report on specific exceptions (currently only NoClassDefFoundError), they are logged but not sent to the main handler.

TBH, I'd prefer to properly fix #19044, but adding --add-opens=jdk.unsupported.desktop/jdk.swing.interop=ALL_UNNAMED to the jnlp java-vm-args didn't help.

Attachments (1)

19169.patch (4.0 KB) - added by taylor.smock 2 months ago.

Download all attachments as: .zip

Change History (2)

Changed 2 months ago by taylor.smock

Attachment: 19169.patch added

comment:1 Changed 4 weeks ago by simon04

Resolution: fixed
Status: newclosed

[o35492:35493]

Thank you!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.