Opened 4 years ago

Last modified 4 years ago

#19148 new defect

Problems with multipolygon consisting of several separate areas with same primary tag but different secondary tags. — at Version 5

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report multipolygon Cc:

Description (last modified by skyper)

This came up in #19136, see my comment 22 and followups.
I've created an example file:
josm_19136_multi_with_same_style_sample.osm

If I have two parts of a forest with a name in common but the parts have different operator and different leaf_type. I need to leave the secondary tags on the parts and maybe use more general values for the multipolygon.

  • Only secondary tags on a area without primary tag is not working
    • "Create multipolygon" just does that
  • Simply adding the name to both parts contradicts: One feature one object
  • Only a cheat, creating multipolygons for each area and an additional one for the group is accepted by validator
  • I do not use type=site as osmwiki:Tag:type=site explicitly stats:

    This relation is not to be used in cases where the element can be represented by one or more areas and neither linear ways nor nodes outside these areas would have to be included or excluded from within these areas.

Multi_Multi (no warning)

Same as "Valid but warning" but with multipolygons for each part. I get no warning.

  • Should trigger the same warnings as "Valid but warning" cause it is just a different mapping style
  • Additional warnings for the "forest" multipolygons without name as are not needed with only one outer without any primary tags

Wood vs Forest

I get With the currently used mappaint style the style for outer way mismatches the area style (2)

  • wood and forest should be treated as synonyms, e.g. no warning

Valid but warning

I get Area style on outer way (2)

  • Right, but not worse a warning as this is a valid case

Incorrect

I get no warning. This is the result of "create multipolygon". Use the two areas on the right side.

  • Both areas do not have a primary tag, needs a warning: Object with only secondary tags
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-23 21:58:14 +0200 (Thu, 23 Apr 2020)
Revision:16376
Build-Date:2020-04-24 01:30:45
URL:https://josm.openstreetmap.de/svn/trunk

Change History (5)

comment:1 by skyper, 4 years ago

Description: modified (diff)

comment:2 by GerdP, 4 years ago

Please review the file. The relation with name="Multi_Multi (No warnings)" contains no special case, just two closed ways without further tags.

in reply to:  2 comment:3 by skyper, 4 years ago

Replying to GerdP:

Please review the file. The relation with name="Multi_Multi (No warnings)" contains no special case, just two closed ways without further tags.

This is intended as example of the cheat to silent validator. It is the same as as "Valid but warning".

I replaced the file cause I had forgotten to remove the note=* from the "forest" multipolygons without name.

comment:4 by GerdP, 4 years ago

OK, please describe in detail what you get and what you expect to happen for each multipolygon in this file.

comment:5 by skyper, 4 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.