Modify

Opened 6 weeks ago

Closed 3 weeks ago

#19147 closed enhancement (fixed)

Add Persian language

Reported by: Claudius Owned by: team
Priority: normal Milestone: 20.05
Component: Core Version:
Keywords: Cc:

Description

Persian (language code: fa) translation on Launchpad just passed the 2000 translated strings milestone and the Persian speaking community would love to see language support shipping with JOSM.

I have attached a patch that adds the plural rule and enables Persian numerals (which is the "arabext" parameter for bcp47 discussed in ticket:18856#comment:13 ) for Iran (where it's the primary language). Not sure if it should be added for Afghanistan as well since the language structure is even more diverse there.

In addition to the JOSM application changes in the patch it seems the i18n script launchpad configuration needs to be expanded with the fa language code similar to [o35350].

Attachments (1)

PersianLanguageSupport.patch (1.1 KB) - added by Claudius 6 weeks ago.

Download all attachments as: .zip

Change History (8)

Changed 6 weeks ago by Claudius

comment:1 Changed 6 weeks ago by stoecker

If there have not been 100 new strings since yesterday Persian is still below the 2000 strings limit:

[exec] Created file ../core/resources/data/fa.lang : Added 1907 strings out of 9080 ( 21.0%).

Also note, that 2000 should be exceeded, I don't want to remove Persion with the next release only because it falls below 2000 again. 2000 really is the minimum!

There are a bunch of errors:

     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: نمی توان {0} پرونده را باز کرد چون پرونده وجود ندارد یا وارد کننده ی پرونده مناسب در دسترس نیست.\r
     [exec] نمی توان {0} پرونده را باز کرد چون پرونده ها وجود ندارند یا وارد کننده ی پرونده مناسب در دسترس نیست.
     [exec] Original text: Cannot open {0} file because file does not exist or no suitable file importer is available.
     [exec] JAVA translation issue for language fa (1): Mismatching format entries:
     [exec] Translated text: نمی توان {0} پرونده را باز کرد چون پرونده وجود ندارد یا وارد کننده ی پرونده مناسب در دسترس نیست.\r
     [exec] نمی توان {0} پرونده را باز کرد چون پرونده ها وجود ندارند یا وارد کننده ی پرونده مناسب در دسترس نیست.
     [exec] Original text: Cannot open {0} file because file does not exist or no suitable file importer is available.
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: نمیتوان {0} پرونده را با وارد کننده پرونده ی ''{1}'' باز کرد.\r
     [exec] نمیتوان {0} پرونده را با وارد کننده پرونده ی ''{1}'' باز کرد.
     [exec] Original text: Cannot open {0} file with the file importer ''{1}''.
     [exec] JAVA translation issue for language fa (1): Mismatching format entries:
     [exec] Translated text: نمیتوان {0} پرونده را با وارد کننده پرونده ی ''{1}'' باز کرد.\r
     [exec] نمیتوان {0} پرونده را با وارد کننده پرونده ی ''{1}'' باز کرد.
     [exec] Original text: Cannot open {0} file with the file importer ''{1}''.
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: ترکیب {0} گره\r
     [exec] ترکیب {0} گره
     [exec] Original text: Merge {0} node
     [exec] JAVA translation issue for language fa (1): Mismatching format entries:
     [exec] Translated text: ترکیب {0} گره\r
     [exec] ترکیب {0} گره
     [exec] Original text: Merge {0} node
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: شیئ را نمیتوان دانلود کرد\r
     [exec] برخی اشیا را نمیتوان دانلود کرد
     [exec] Original text: Object could not be downloaded
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: شیئ حذف شد\r
     [exec] اشیا حذف شدند
     [exec] Original text: Object deleted
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: یک شیئ دانلود شده حذف شد.\r
     [exec] {0} شیئ دانلود شده حذف شد.
     [exec] Original text: One downloaded object is deleted.
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: یک شیئ را نمیتوان دانلود کرد.<br>\r
     [exec] {0} شیئ را نمیتوان دانلود کرد.<br>
     [exec] Original text: One object could not be downloaded.<br>
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: باز کردن {0} پرونده...\r
     [exec] باز کردن {0} پرونده...
     [exec] Original text: Opening {0} file...
     [exec] JAVA translation issue for language fa (1): Mismatching format entries:
     [exec] Translated text: باز کردن {0} پرونده...\r
     [exec] باز کردن {0} پرونده...
     [exec] Original text: Opening {0} file...
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: چسباندن {0} برچسب\r
     [exec] چسباندن {0} برچسب
     [exec] Original text: Pasting {0} tag
     [exec] JAVA translation issue for language fa (1): Mismatching format entries:
     [exec] Translated text: چسباندن {0} برچسب\r
     [exec] چسباندن {0} برچسب
     [exec] Original text: Pasting {0} tag
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: راه انتخابی گره های خارج از منطقه دانلود شده دارد.\r
     [exec] راه های انتخابی گره های خارج از منطقه دانلود شده دارند.
     [exec] Original text: The selected way has nodes outside of the downloaded data region.
     [exec] JAVA translation issue for language fa: \r in string:
     [exec] Translated text: به {0} شیئ\r
     [exec] به {0} شیئ
     [exec] Original text: to {0} object
     [exec] JAVA translation issue for language fa (1): Mismatching format entries:
     [exec] Translated text: به {0} شیئ\r
     [exec] به {0} شیئ
     [exec] Original text: to {0} object

comment:2 Changed 6 weeks ago by Claudius

Thanks for looking at the Persian language import. I did indeed translate more than 100 new strings since yesterday. Also a bunch are currently in review and we are just increasing our ternlation effort over the weekend.
I will look at the issues flagged. It's a bit odd that Launchpad allows these to be created at first.

comment:3 in reply to:  2 Changed 6 weeks ago by stoecker

Replying to Claudius:

Thanks for looking at the Persian language import. I did indeed translate more than 100 new strings since yesterday. Also a bunch are currently in review and we are just increasing our ternlation effort over the weekend.

Still 1907. Limit is not yet reached.

I will look at the issues flagged. It's a bit odd that Launchpad allows these to be created at first.

Launchpad checks a lot of errors already, but not everything we reject must also be false for other projects.

comment:4 Changed 6 weeks ago by Claudius

I am checking "translated items" on Launchpad which right now shows a count of 2063. But maybe that's more than just core strings though. We'll keep translating :)
I should have meanwhile fixed all the bugs flagged in your first review though.

comment:5 Changed 3 weeks ago by simon04

Milestone: 20.05

@stoecker, it seems we're ready to add now? – 2093 strings

Created file ../core/resources/data/fa.lang         : Added  2093 strings out of  9090 ( 23.0%).

comment:6 Changed 3 weeks ago by stoecker

In 16439/josm:

Add Persian language, see #19147, readd Icelandic, i18n update

comment:7 Changed 3 weeks ago by stoecker

Resolution: fixed
Status: newclosed

Fixed in [osm35457].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.