Some kind of bug around dates

[Stereo]

What steps will reproduce the problem?

1. Add a tile server

What is the expected result?

Tiles get displayed

What happens instead?

Exception. No tiles.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 02:17:07 +0200 (Mon, 06 Apr 2020)
Revision:16239
Build-Date:2020-04-06 00:18:43
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16239 en_GB) Mac OS X 10.15.4
OS Build number: Mac OS X 10.15.4 (19E287)
Memory Usage: 4096 MB / 4096 MB (2365 MB allocated, but free)
Java version: 14.0.1+7, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Screen: Display 69733632 1680x1050
Maximum Screen Size: 1680x1050
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (35405)
+ CommandLine (35405)
+ ImportImagePlugin (35248)
+ Mapillary
+ MovementAlert (1511141840)
+ OpeningHoursEditor (35414)
+ PicLayer (35405)
+ RelationDissolve (0.2.0)
+ alignways (35405)
+ apache-commons (35362)
+ apache-http (35092)
+ areaselector (359)
+ austriaaddresshelper (57)
+ buildings_tools (35405)
+ changeset-viewer (22)
+ conflation (0.6.4)
+ continuosDownload (91)
+ contourmerge (v0.1.6)
+ ejml (35313)
+ geotools (35169)
+ gridify (1577091848)
+ http2 (35356)
+ imagery-xml-bounds (35313)
+ jaxb (35092)
+ jna (35092)
+ jogl (1.2.3)
+ jts (35122)
+ log4j (35092)
+ opendata (35405)
+ openqa (0.1.9)
+ poly (35248)
+ public_transport (35405)
+ reltoolbox (35405)
+ reverter (35409)
+ splinex (35405)
+ terracer (35327)
+ todo (30306)
+ undelete (35405)
+ utilsplugin2 (35405)
+ wikipedia (1.1.3)

Last errors/warnings:
- E: Handled by bug report queue: java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26
- W: Too many errors. Dropping ReportedException [thread=Thread[TMS-downloader-93,5,main], exception=java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26, methodWarningFrom=BugReportExceptionHandler#handleException]
- E: Handled by bug report queue: java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26
- W: Too many errors. Dropping ReportedException [thread=Thread[TMS-downloader-95,5,main], exception=java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26, methodWarningFrom=BugReportExceptionHandler#handleException]
- E: Handled by bug report queue: java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26
- W: Too many errors. Dropping ReportedException [thread=Thread[TMS-downloader-97,5,main], exception=java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26, methodWarningFrom=BugReportExceptionHandler#handleException]
- E: Handled by bug report queue: java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26
- W: Too many errors. Dropping ReportedException [thread=Thread[TMS-downloader-96,5,main], exception=java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26, methodWarningFrom=BugReportExceptionHandler#handleException]
- E: Handled by bug report queue: java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26
- W: Too many errors. Dropping ReportedException [thread=Thread[TMS-downloader-98,5,main], exception=java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26, methodWarningFrom=BugReportExceptionHandler#handleException]


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: TMS-downloader-19 (115)
java.time.format.DateTimeParseException: Text 'Thu, 01 Jan 1970 01:00:00 CET' could not be parsed at index 26
	at java.base/java.time.format.DateTimeFormatter.parseResolved0(Unknown Source)
	at java.base/java.time.format.DateTimeFormatter.parse(Unknown Source)
	at java.base/java.util.Optional.map(Unknown Source)
	at org.openstreetmap.josm.plugins.http2.Http2Client$Http2Response.getExpiration(Http2Client.java:178)
	at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.parseHeaders(JCSCachedTileLoaderJob.java:474)
	at org.openstreetmap.josm.data.imagery.TMSCachedTileLoaderJob.parseHeaders(TMSCachedTileLoaderJob.java:260)
	at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.loadObject(JCSCachedTileLoaderJob.java:337)
	at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.run(JCSCachedTileLoaderJob.java:225)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

[simon04]

The given date "Thu, 01 Jan 1970 01:00:00 CET" is invalid according to ​https://tools.ietf.org/html/rfc2616#section-3.3.1

All HTTP date/time stamps MUST be represented in Greenwich Mean Time (GMT), without exception.

However, the plugin probably shouldn't crash.

The old-school HttpUrlConnection uses the deprecated function Date.parse() for parsing.