Attachments (2)
Change History (11)
by , 5 years ago
Attachment: | 2020-04-20-231812_405x248_scrot.png added |
---|
by , 5 years ago
Attachment: | 19127.patch added |
---|
follow-up: 4 comment:1 by , 5 years ago
follow-ups: 3 5 comment:2 by , 5 years ago
Replying to simon04:
- [...], the map view moves to the first result
Well, fine for the unique "Innsbruck". But what about "Kirchdorf" (32 locations) or "Neustadt" (51 locations)?
comment:3 by , 5 years ago
comment:4 by , 5 years ago
Replying to Klumbumbus:
One little thing might be good: if I understand right you hardcoded Nominatim? Better use the search engine the user chose at wiki:Help/Action/Download#Areaaroundplaces. Currently there is only Nominatim available, but once we add another again we'll probably forget to adapt the jump to position dialog.
Currently, the logic of handling multiple servers is inside the UI class source:trunk/src/org/openstreetmap/josm/gui/download/PlaceSelection.java
When we add an additional geocoder, we'll very likely have to adapt/generify the parsing code as well. I don't really see the point in making this code generic considering that Nominatim has been the only geocoder since r4422.
Btw: I'm co-maintaining the JavaScript library leaflet-control-geocoder which offers a uniform interface for 11 geocoders (some/most requiring an API token).
comment:5 by , 5 years ago
Replying to Hb---:
Well, fine for the unique "Innsbruck". But what about "Kirchdorf" (32 locations) or "Neustadt" (51 locations)?
I'm aware of the ambiguity. The solution is easy: make the query more specific, such as Neustadt, Hesse
or Neustadt, Kronstadt
For this feature, I'd like to follow the approach "immediate result, reiterate if necessary" instead of providing an additional dialog for selecting the right entry (since there will almost always be something to choose from).
comment:8 by , 5 years ago
Milestone: | → 20.05 |
---|
comment:9 by , 4 years ago
There is one comment on facebook about the new box. Not sure if we really want to make an advanced preference to hide this box. Or move it to the bottom. But I think on the top it is better because if you use lat and lon you anyway need to use tab or mouse. (However I don't use jump to position at all.)
Good idea. One little thing might be good: if I understand right you hardcoded Nominatim? Better use the search engine the user chose at wiki:Help/Action/Download#Areaaroundplaces. Currently there is only Nominatim available, but once we add another again we'll probably forget to adapt the jump to position dialog.