Modify

Opened 9 months ago

Closed 8 months ago

Last modified 8 months ago

#19081 closed enhancement (fixed)

[PATCH] Add amenity=public_bath

Reported by: EliasJonsson Owned by: Klumbumbus
Priority: normal Milestone: 20.05
Component: Internal preset Version:
Keywords: template_report Cc:

Description (last modified by Klumbumbus)

What steps will reproduce the problem?

  1. Create node with properties amenity=public_bath

What is the expected result?

An icon, showing that there's a public bath
https://wiki.openstreetmap.org/w/images/thumb/0/01/Public_bath.svg/120px-Public_bath.svg.png

What happens instead?

Blue dot showing

Please provide any additional information below. Attach a screenshot if possible.

osmwiki:Tag:amenity=public_bath

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 09:47:17 +0200 (Mon, 06 Apr 2020)
Build-Date:2020-04-07 01:30:48
Revision:16243
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16243 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 247 MB / 247 MB (44 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1440x900
Maximum Screen Size: 1440x900
Dataset consistency test: No problems found

Plugins:
+ BuildingGeneralization (23)
+ auto_tools (73)
+ buildings_tools (35405)
+ editgpx (35248)
+ reltoolbox (35405)
+ utilsplugin2 (35405)

Last errors/warnings:
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out

Attachments (6)

120px-Public_bath.svg.png (3.0 KB) - added by EliasJonsson 9 months ago.
screenshot-no-bath-sign.jpg (358.6 KB) - added by EliasJonsson 9 months ago.
#19081_--_Preset_for_public_bath.patch (4.6 KB) - added by hiddewie 8 months ago.
#19081_--_Preset_for_public_bath.2.patch (8.4 KB) - added by hiddewie 8 months ago.
Screenshot from 2020-05-23 10-25-53.png (170.0 KB) - added by hiddewie 8 months ago.
screenshot of all 3 modals
#19081_--_Preset_for_public_bath1.patch (7.2 KB) - added by hiddewie 8 months ago.

Download all attachments as: .zip

Change History (17)

Changed 9 months ago by EliasJonsson

Attachment: 120px-Public_bath.svg.png added

Changed 9 months ago by EliasJonsson

Attachment: screenshot-no-bath-sign.jpg added

comment:1 Changed 9 months ago by Klumbumbus

Component: CoreInternal preset
Description: modified (diff)
Summary: amenity:public_bath does not have an iconAdd amenity=public_bath
Type: defectenhancement

Changed 8 months ago by hiddewie

comment:3 Changed 8 months ago by hiddewie

Summary: Add amenity=public_bath[PATCH] Add amenity=public_bath

comment:4 Changed 8 months ago by skyper

I think we need more explanation/words in this preset and preset_links from one to the others to difference it from leisure=waterpark and leisure=sports_centre + sport=swimming.

comment:5 Changed 8 months ago by skyper

How about adding more tags like using <references ref="name_operator_oh_wheelchair" /> and <reference ref="link_contact_address_payment" />

Changed 8 months ago by hiddewie

Changed 8 months ago by hiddewie

screenshot of all 3 modals

comment:6 Changed 8 months ago by Klumbumbus

Milestone: 20.05
Owner: changed from team to Klumbumbus
Status: newassigned

comment:7 Changed 8 months ago by Klumbumbus

Resolution: fixed
Status: assignedclosed

In 16479/josm:

fix #19081 - Add amenity=public_bath (based on patch by hiddewie, icon from https://wiki.openstreetmap.org/wiki/File:Public_bath.svg, CC0 and PD licensed)

comment:8 Changed 8 months ago by Klumbumbus

For detailed tag descriptions we should use a more genral solution, like #17842.

Changed 8 months ago by hiddewie

comment:9 Changed 8 months ago by hiddewie

OK! Removed the textual lines until the wiki data can be used automatically.

comment:10 Changed 8 months ago by Klumbumbus

I did already add the preset, see comment:7.

comment:11 Changed 8 months ago by hiddewie

Ah perfect, I missed that. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.