Presets: validate user input (w.r.t. regexp/validator)

[simon04]

• Inserting width=2,5 in the Highway/Ways/Track preset should immediately give me the validation warning "unusual value of width: use . instead of , as decimal separator"
• Inserting maxspeed=50 km/h in the Highway/Ways/Residential preset should immediately give me the validation warning "unusual value of maxspeed"
• Inserting an invalid opening_hours value should immediately give me a corresponding validation warning

Colouring the background of the text/combo inputs in green (for successful validation) or in red (for unsuccessful validation) would be very helpful.

The question is how to tie the validation checks to the key/value in the preset dialog

[skyper]

Why restrict this to presets. Add tag and Change value could profit, too.

For actions see #3496.

[Klumbumbus]

Milestone renamed

[simon04]

In 17642/josm:

see #19078 - Common interface TagCondition

[simon04]

In 17643/josm:

see #19078 - Presets: validate user input (using MapCSSTagChecker, OpeningHourTest)

This feature is disabled by default and can be activated by setting the advanced preference taggingpreset.validator to true.

[simon04]

In 17651/josm:

see #19078 - Preset preference: extract property constants

[simon04]

In 17652/josm:

see #19078 - Preset preference: checkbox for validate user input

[simon04]

Done for the 21.03 milestone. Depending on the feedback, I'm considering to enable this feature by default in one of the next milestones.

[skyper]

Replying to simon04:

In 17652/josm:

see #19078 - Preset preference: checkbox for validate user input

Actually, I would prefer to have settings for tagging presets, map paint styles and imagery all in an own, separate tab within the corresponding preferences' register, keeping a consistent look of the first tab of these register. Validator might be another candidate as atm settings and tests are combined in the first tab.

[simon04]

@skyper, no objections. Since this is only loosely related to this enhancement and will not make it into milestone:21.03, please open a separate ticket. Thanks!

[skyper]

No problem, see #20688 and #20689.

As documentation needs some updates, I was just asking before creating new screenshots and changing the structure of the wiki pages.

[skyper]

Does not work with all tests/rules, see #21041.