Modify ↓

Opened 5 years ago

Closed 5 years ago

#19060 closed defect (fixed)

cannot undo "add mapillary tag"

Reported by: bxm@… Owned by: jpietri
Priority: normal Milestone:
Component: Plugin mapillary Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. select object (e.g. node or way)
  2. use "add mapillary tag" in mapillary plugin
  3. try "undo" function - does not work

What is the expected result?

undo added mapillary tag

What happens instead?

undoes previous action, leaves added mapillary tag unchanged

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 02:17:07 +0200 (Mon, 06 Apr 2020)
Build-Date:2020-04-06 00:18:43
Revision:16239
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16239 en) Windows 7 64-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 915 MB / 1749 MB (209 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 2560x1440
Maximum Screen Size: 2560x1440
Dataset consistency test: No problems found

Plugins:
+ BuildingGeneralization (23)
+ CADTools (1008)
+ EasyPresets (1583691763)
+ ImageWayPoint (35248)
+ Mapillary (1.5.21)
+ PolygonCutOut (v0.7)
+ QuickLabel (18)
+ RoadSigns (35405)
+ apache-commons (35362)
+ apache-http (35092)
+ auto_tools (73)
+ buildings_tools (35405)
+ changeset-viewer (22)
+ imagery_offset_db (35405)
+ javafx-windows (35375)
+ jna (35092)
+ measurement (35405)
+ openvisible (35248)
+ reverter (35409)
+ turnrestrictions (35405)
+ utilsplugin2 (35405)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Stolpersteine&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/StolpersteineLight&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
+ D:\Portable Programme (non-install)\JOSM\Styles_Modified-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- E: Failed to locate image 'modified_objects_style_icon.svg'
- W: Mappaint style "standard" (Modified objects) icon "modified_objects_style_icon.svg" not found.
- E: Failed to locate image 'traffic_signs_presets/ES_tertiary.png'
- W:  Tertiary: Could not get presets icon traffic_signs_presets/ES_tertiary.png
- W: Region [userProfile_BLOCK_v2]  Problem verifying disk.
- E: Trying to get https://www.mapillary.com/developer/api-documentation/images/traffic_sign/general--traffic-sign--g1.png general--traffic-sign--g1
- W: Failed to download icon. ID unknown to the icon list: general--traffic-sign--g1: java.io.IOException: The requested URL https://www.mapillary.com/developer/api-documentation/images/traffic_sign/general--traffic-sign--g1.png was not found

Attachments (0)

Change History (2)

comment:1 by taylor.smock, 5 years ago

Component: Core → Plugin mapillary
Owner: changed from team to jpietri

It looks like the issue is in Mapillary's src/main/java/org/openstreetmap/josm/plugins/mapillary/gui/imageinfo/AddTagToPrimitiveAction.java file.

It doesn't use commands or add to the command stack. A fairly simple fix. The fix probably won't be released for a while though. (Sorry).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain jpietri.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.