Modify

Opened 8 months ago

Closed 8 months ago

Last modified 7 months ago

#19018 closed enhancement (fixed)

[Patch] Flag combination of major highway type (trunk .. residential) and crossing=*

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.05
Component: Core validator Version:
Keywords: Cc: Klumbumbus

Description

A way with highway=* + crossing=* should be a minor way, typically footway, cycleway or path.
If the tag crossing=* is used on a major way there is probably a missunderstanding.

Attachments (2)

19018.patch (1.0 KB) - added by GerdP 8 months ago.
mapcss rule
19018.2.patch (1.1 KB) - added by GerdP 8 months ago.
positive list

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 months ago by GerdP

I tried this overpass query

[out:xml][timeout:90];
(
  way["crossing"]["highway"]["highway"!="footway"]["highway"!="cycleway"]["highway"!="path"];
);
(._;>;);
out meta;

and got 1510 ways all over the world with 28 different highway tags.
highway=construction and highway=proposed are probably okay, highway=crossing is already flagged in a different test.
Maybe a highway=bridleway is also acceptable? It is often used in a small part of Mexico.

Changed 8 months ago by GerdP

Attachment: 19018.patch added

mapcss rule

comment:2 Changed 8 months ago by GerdP

Cc: Klumbumbus added
Summary: Flag combination of major highway type (trunk .. residential) and crossing=*[Patch] Flag combination of major highway type (trunk .. residential) and crossing=*

@Klumbumbus: What do you think?

comment:3 Changed 8 months ago by Klumbumbus

Milestone: 20.04

I would exclude highway=pedestrian and crossing=no too. With highway=bridleway excluded too 780 ways remain:

[out:xml][timeout:90];
(
  way["crossing"]["highway"]["highway"!="footway"]["highway"!="cycleway"]["highway"!="path"]["highway"!="construction"]["highway"!="proposed"]["highway"!="crossing"]["highway"!="pedestrian"]["highway"!="bridleway"]["crossing"!="no"];
);
(._;>;);
out meta;

I didn't notice false positives on a quick sample.

And adjusting the text to ...Should be used on a minor highway type or node.

comment:4 Changed 8 months ago by GerdP

OK, let's use that.

Changed 8 months ago by GerdP

Attachment: 19018.2.patch added

positive list

comment:5 Changed 8 months ago by GerdP

With the suggested changes I find these rather confusing messages:

crossing together with highway=alley. Should be used on a minor highway type or a node (14)
crossing together with highway=corridor. Should be used on a minor highway type or a node (12)
crossing together with highway=footway;crossing. Should be used on a minor highway type or a node (1)
crossing together with highway=platform. Should be used on a minor highway type or a node (1)
crossing together with highway=road. Should be used on a minor highway type or a node (1)
crossing together with highway=sidewalks. Should be used on a minor highway type or a node (2)
crossing together with highway=steps. Should be used on a minor highway type or a node (50)
crossing together with highway=traffic_signals. Should be used on a minor highway type or a node (2)
crossing together with highway=yes. Should be used on a minor highway type or a node (1)

We would find all kinds of typos in the highway here. Those should better be reported with a different message.I think it would be better to use a positive list. I copied a statement found in unnecessary.mapcss.

comment:6 Changed 8 months ago by GerdP

Resolution: fixed
Status: newclosed

In 16256/josm:

Fix #19018: Flag combination of major highway type (trunk .. residential) and crossing=*

comment:7 Changed 7 months ago by Klumbumbus

Milestone: 20.0420.05

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.