Modify

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#19011 closed defect (fixed)

JOSM imagery, geojson output is not correct geojson

Reported by: SimonPoole Owned by: Don-vip
Priority: normal Milestone: 20.03
Component: Core imagery Version:
Keywords: geojson Cc:

Description

See https://josm.openstreetmap.de/maps?format=geojson

The top level object should be a FeatureCollection, but is missing "type": "FeatureCollection" either before or after the "features" array.

Attachments (0)

Change History (8)

comment:1 Changed 2 months ago by Stereo

Thanks Simon! The fix is relatively easy, but has to happen internally in Trac.

On line 366 in Trac's JOSM.py, replace:

j = {"features": []}

with

j = {"type": "FeatureCollection", "features": []}

comment:2 Changed 2 months ago by Don-vip

Keywords: geojson added
Milestone: 20.03
Owner: changed from team to Don-vip
Status: newassigned

comment:3 Changed 2 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

Thank you both!

comment:4 Changed 2 months ago by simon04

Just out of curiosity, where can the JOSM.py be found (to get an idea of the magic hidden behind JOSM Trac)?

comment:5 Changed 2 months ago by Don-vip

It's not public yet, I shared it with Stereo as he was interested to help us in imagery list. Check your e-mails :)

comment:6 Changed 2 months ago by skyper

Thanks, now JOSM is back in taginfo`s project listings.

comment:7 Changed 2 months ago by Stereo

taginfo has a project listing that depends on valid geojson?

comment:8 Changed 2 months ago by Don-vip

This is completely unrelated please don't mix different subjects.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.