#18994 closed defect (fixed)
[Patch] With a MultiPolygon Relation, the values for the Preset Facilities/Education/School are saved within the Relation, whilst other presets are not.
| Reported by: | AlexKemp | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 20.05 |
| Component: | Internal preset | Version: | |
| Keywords: | template_report closedway multipolygon area | Cc: |
Description
What steps will reproduce the problem?
- Load the Relation "https://www.openstreetmap.org/relation/4772786" into JOSM
What is the expected result?
All Tags to be accessible & editable via the same window
(I no longer know which is the 'correct' window, now)
What happens instead?
- amenity=school can only be accessed & edited by using Edit on the MultiPolygon
- Annotation/Address + Annotation/Contact are each accessible via the "normal" Tags window
Please provide any additional information below. Attach a screenshot if possible.
When I began editing this Relation, ALL Tags & presets were within the Relation, and only accessible via the multipolygon member. After using the Presets - starting with School - some values were dropped into the Multipolygon window & others into the Tags window. Even as a seasoned JOSM user that is *very* confusing. I also do not recall any relations carrying vast numbers of Tags.
The Annotation presets are now available from Tags, whilst School is only accessible from Relation. I've stopped editing it as to try to not confuse the issue any further.
I've been editing a lot of schools recently & have met problems with multipolygons. This is the first time that I've had such a clearcut example to present as a bug report. I shall upload the results as they stand, so that (like a toddler proudly presenting his dump) you can see the result for yourself.
URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2020-03-26 20:53:34 +0100 (Thu, 26 Mar 2020) Build-Date:2020-03-27 02:30:56 Revision:16201 Relative:URL: ^/trunk Identification: JOSM/1.5 (16201 en_GB) Linux Devuan GNU/Linux 2.1 (ascii) Memory Usage: 857 MB / 1646 MB (247 MB allocated, but free) Java version: 1.8.0_242-8u242-b08-1~deb9u1-b08, Oracle Corporation, OpenJDK 64-Bit Server VM Screen: :0.0 1366x768 Maximum Screen Size: 1366x768 Java package: openjdk-8-jre:amd64-8u242-b08-1~deb9u1 libcommons-logging-java: libcommons-logging-java:all-1.2-1 fonts-noto: fonts-noto:- VM arguments: [-Djosm.restart=true, -Djosm.dir.name=JOSM-latest, -Djava.net.useSystemProxies=true] Dataset consistency test: No problems found Plugins: + DirectUpload (35248) + Mapillary (1.5.20) + apache-commons (35362) + apache-http (35092) + buildings_tools (35364) + continuosDownload (91) + ejml (35122) + geotools (35169) + jaxb (35092) + jna (35092) + jts (35122) + opendata (35330) + photo_geotagging (35313) + photoadjust (35313) + terracer (35327) + utilsplugin2 (35384) + waydownloader (35092) Last errors/warnings: - W: Failed to parse external taginfo data at https://josm.openstreetmap.de/remote/geofabrik-index-v1-nogeom.json: Invalid token=EOF at (line no=6882, column no=1932, offset=403684). Expected tokens are: [CURLYOPEN, SQUAREOPEN, STRING, NUMBER, TRUE, FALSE, NULL] - W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html> - W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html> - W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
Attachments (2)
Change History (10)
by , 5 years ago
| Attachment: | Screenshot_2020-03-27_16-08-24.png added |
|---|
comment:1 by , 5 years ago
| Component: | Core → Internal preset |
|---|---|
| Keywords: | closedway multipolygon area added |
comment:2 by , 5 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
You added tags to the relation https://www.openstreetmap.org/relation/4772786 and the way https://www.openstreetmap.org/way/696242633. When adding tags you need to decide to which object (relation or way) you want to add the tags and select only that object, not both.
follow-up: 4 comment:3 by , 5 years ago
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
The screenshot might be wrong but the problem exists.
- Have a multipolygon with
amenity=school - Select the relation
- no preset link in Tags/Memberships panel
comment:4 by , 5 years ago
Replying to skyper:
The screenshot might be wrong but the problem exists.
- Have a multipolygon with
amenity=school- Select the relation
- no preset link in Tags/Memberships panel
Oh, sorry, the example is wrong, too.
Have a look at man_made=* for valid examples, like light_house or tower. In general, all presets for areas need type="closedway,multipolygon
comment:5 by , 5 years ago
| Summary: | With a MultiPolygon Relation, the values for the Preset Facilities/Education/School are saved within the Relation, whilst other presets are not. → [Patch] With a MultiPolygon Relation, the values for the Preset Facilities/Education/School are saved within the Relation, whilst other presets are not. |
|---|
Please, have a look at josm_18994.patch which adds some type="multipolygon".
I was unsure with some highway=* and some members of certain route relations like hiking or bicycle which may lead across pedestian areas mapped as multipolygon.
by , 5 years ago
| Attachment: | josm_18994.patch added |
|---|
patch adds type=multipolygon to several presets
comment:6 by , 5 years ago
| Milestone: | → 20.04 |
|---|
Problem is the object type restriction in defaultpresets. Many presets allow
closedwaybut notmultipolygon. If closedway is equal to area multipolygons should be allowed, too.