Modify

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#18979 closed enhancement (fixed)

Improve display of PrimitiveIds

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.03
Component: Core Version:
Keywords: undelete Cc:

Description (last modified by GerdP)

I try to fix #10783. I want to show a popup dialog with the list of objects which were not found on the server. We already have a solution for this problem in class DownloadPrimitivesWithReferrersTask. Try for example to download objects "w2,n3,r123456789"
(w2 was redacted, n3 was deleted, r123456789 doesn't yet exist)
I could reuse this dialog after changing DownloadPrimitivesWithReferrersTask.reportProblemDialog() to public but I don't like the way how ids are reported.
Instead of "relation 123456789, way 2" I'd prefer "w2,r123456789" or "w2, r123456789".
This is the input format used in
Order probably doesn't matter, at the moment it is random because unordered collections are used to store the ids.

Attachments (2)

improved.PNG (11.3 KB) - added by GerdP 8 months ago.
18979-local.patch (1.3 KB) - added by GerdP 8 months ago.
solution with minimal impact

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 months ago by GerdP

Description: modified (diff)

Changed 8 months ago by GerdP

Attachment: improved.PNG added

comment:2 Changed 8 months ago by GerdP

Description: modified (diff)

Changed 8 months ago by GerdP

Attachment: 18979-local.patch added

solution with minimal impact

comment:3 Changed 8 months ago by GerdP

I thought that there might be more places where collections of ids are reported but found none so far. So, I'll commit the simple patch tomorrow if nobody complains or suggests a better place to implement this.

comment:4 Changed 8 months ago by skyper

Places to check are the download actions in changeset manager, see #17978, and the reverter plugin.

comment:5 Changed 8 months ago by skyper

Download location, see #8946.

comment:6 Changed 8 months ago by GerdP

How is #8946 related to the display of ids?

comment:7 in reply to:  6 Changed 8 months ago by skyper

Replying to GerdP:

...
Order probably doesn't matter, at the moment it is random because unordered collections are used to store the ids.

How does the undelete plugin handle situations when the child object is in the list behind its parent?
Is it not better to order it by object type (nodes, ways, relations)

Replying to GerdP:

How is #8946 related to the display of ids?

The request is not related but the example is a valid use case where the message should include a well formated string for undelete

Last edited 8 months ago by skyper (previous) (diff)

comment:8 Changed 8 months ago by GerdP

Resolution: fixed
Status: newclosed

In 16204/josm:

fix #18979: Improve display of PrimitiveIds
Show e.g. "w2, r123456789" instead of "way 2, relation 123456789" so that output matches the expected input format for object downloads

comment:9 Changed 8 months ago by Klumbumbus

Milestone: 20.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.