Way.hasIncompleteNodes() should remember the result

[GerdP]

Since Way.isUsable() calls this method we should store the result in a Boolean instead of doing the

Arrays.stream(nodes).anyMatch(Node::isIncomplete);

again and again. Most ways don't have incomplete nodes.

[GerdP]

Would this be the right way to do it?

[Don-vip]

A flag is better. No need to add an additional boolean for all ways where a single bit is needed.

[Don-vip]

While you're at it, you can modify the Relation class to also use this new flag for hasIncompleteMembers() implementation.

[GerdP]

OK, I try. my first patch doesn't work anyway as a way is not updated when a node changes its status regarding incompleteness. Please check OsmPrimitive.setIncomplete(). Why does it fire PrimitiveRemoved or PrimitiveAdded?
This looks like a copy&paste error made in r3348, code for setDeleted() and setIncomplete() were both changed.

[Don-vip]

Replying to GerdP:

Please check OsmPrimitive.setIncomplete(). Why does it fire PrimitiveRemoved or PrimitiveAdded?
This looks like a copy&paste error made in r3348

Comes from r2623.

[GerdP]

OK. I found no code which actually evaluates the boolean flag.

[GerdP]

I wonder if this could explain some of the "IAE: Node is already deleted" errors?

[GerdP]

use flags, remember status also for relations, add unit tests

[GerdP]

Please review. I don't fully understand the meaning of the allowWithoutDataset flag in OsmPrimitive.referrers(boolean allowWithoutDataset, Class<T> filter)

[simon04]

Is the performance of Way.hasIncompleteNodes an actual issue? I dislike the complexity of the update mechanism – it's spread over many functions and hard to reason about…

An alternative approach could be to cache ALL_COMPLETE_NODES as flag (this assumes that a node will never transition from complete to incomplete), such as shown in this draft:

// org.openstreetmap.josm.data.osm.Way
    public boolean hasIncompleteNodes() {
        if ((flags & ALL_COMPLETE_NODES) != 0) {
            return false;
        }
        boolean isIncomplete = Arrays.stream(nodes).anyMatch(Node::isIncomplete);
        if (!isIncomplete) {
            updateFlags(ALL_COMPLETE_NODES, true);
        }
        return isIncomplete;
    }

    private static final short ALL_COMPLETE_NODES = 1 << 14;