Improve performance of validator checks

[GerdP]

Some tests are executed for each element of the data set although they are only interested in tagged objects. Mosts tests which extend Test.TagTest should override method isPrimitiveUsable() like this to check isTagged() first:

    @Override
    public boolean isPrimitiveUsable(OsmPrimitive p) {
        return p.isTagged() && super.isPrimitiveUsable(p);
    }

to improve performance.
Be careful, see r16154

[GerdP]

In 16198/josm:

see #18969: Improve performance of validator checks

[Don-vip]

Does it really improve performance? If yes, I don't understand how.

[GerdP]

For most nodes p.isTagged() return false.
Without the change we calculate

p.isUsable() && (!(p instanceof Way) || (((Way) p).getNodesCount() > 1));
p.accept(this) -> visitor.visit(this) ->  check(n) 

In Lanes.check(n) we do three times e.g. tr("Number of lane dependent values inconsistent") followed by a p.keySet().stream() which creates an empty collection for those untagged nodes.
The three tr() calls should probably not be done in check for each primitive?

[Don-vip]

ok thanks :)