presets: columns="" and rows="" not working anymore

[skyper]

Edit: The problem is in core and not the plugin

What steps will reproduce the problem?

1. Have a preset including <checkgroup columns="3"> and/or <multiselect rows="5" />. e.g. see wiki:Presets/MastAndTower
2. (Open Tagging-Preset-Tester)
3. Take a look at preset "Small communication tower"

What is the expected result?

• Three checks per column
• Multiselect with only five rows

What happens instead?

• One check per column
• More than five rows

Please provide any additional information below. Attach a screenshot if possible.

The column part is also visible with defaultpresets. Take a look at payment=*

With tested (r15937) everything is working.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-18 21:48:50 +0100 (Wed, 18 Mar 2020)
Revision:16173
Build-Date:2020-03-19 02:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Plugins:
+ tagging-preset-tester (35267)

Tagging presets:
+ ${HOME}/Downloads/tower/Presets_MastAndTower-preset.xml

Last errors/warnings:
- E: Failed to locate image ''
- E: Failed to locate image 'Mast_communication.svg'
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image 'Mast_communication.svg'
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image ''

[skyper]

Ah, it is not working at all. The fault is in core and not the plugin.

[skyper]

r16038 is working r16046 not.

[skyper]

#18864 is the ticket to blame.

[Don-vip]

Probable regression of r16042

[Don-vip]

@Simon: Don't we need setters that take a String argument for all non-String preset fields?

[simon04]

In 16180/josm:

fix #18954, see #18864 - TaggingPresetReader: read short types

[simon04]

In 16181/josm:

see #18954, see #18864 - Introduce StringParser for parsing various types

[Don-vip]

Nice! :)

[stoecker]

Replying to Don-vip:

Nice! :)

Yeah, that code was ugly.

[simon04]

In 16184/josm:

see #18954, see #18864 - Introduce GenericParser for Cascade.convertTo

[simon04]

In 16188/josm:

see #18954, see #18864 - fix SonarQube issues