Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#18954 closed defect (fixed)

presets: columns="" and rows="" not working anymore

Reported by: skyper Owned by: simon04
Priority: major Milestone: 20.03
Component: Core Version: latest
Keywords: template_report preset rows columns regression Cc: simon04

Description (last modified by skyper)

Edit: The problem is in core and not the plugin

What steps will reproduce the problem?

  1. Have a preset including <checkgroup columns="3"> and/or <multiselect rows="5" />. e.g. see wiki:Presets/MastAndTower
  2. (Open Tagging-Preset-Tester)
  3. Take a look at preset "Small communication tower"

What is the expected result?

  • Three checks per column
  • Multiselect with only five rows

What happens instead?

  • One check per column
  • More than five rows

Please provide any additional information below. Attach a screenshot if possible.

The column part is also visible with defaultpresets. Take a look at payment=*

With tested (r15937) everything is working.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-18 21:48:50 +0100 (Wed, 18 Mar 2020)
Revision:16173
Build-Date:2020-03-19 02:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Plugins:
+ tagging-preset-tester (35267)

Tagging presets:
+ ${HOME}/Downloads/tower/Presets_MastAndTower-preset.xml

Last errors/warnings:
- E: Failed to locate image ''
- E: Failed to locate image 'Mast_communication.svg'
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image 'Mast_communication.svg'
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image ''

Attachments (0)

Change History (18)

comment:1 Changed 3 months ago by skyper

Summary: columns= and rows= not supportedcolumns="" and rows="" not supported

comment:2 Changed 3 months ago by skyper

Component: Plugin tagging-preset-testerCore
Description: modified (diff)
Keywords: preset regression added
Summary: columns="" and rows="" not supportedpresets: columns="" and rows="" not working anymore
Version: latest

Ah, it is not working at all. The fault is in core and not the plugin.

comment:3 Changed 3 months ago by skyper

Description: modified (diff)

comment:4 Changed 3 months ago by skyper

Description: modified (diff)

comment:5 Changed 3 months ago by skyper

Priority: normalmajor

comment:6 Changed 3 months ago by skyper

Description: modified (diff)

r16038 is working r16046 not.

comment:7 Changed 3 months ago by skyper

Description: modified (diff)

comment:8 Changed 3 months ago by skyper

#18864 is the ticket to blame.

comment:9 Changed 3 months ago by Klumbumbus

Cc: simon04 added
Milestone: 20.03

comment:10 Changed 3 months ago by Don-vip

Probable regression of r16042

comment:11 Changed 3 months ago by simon04

Owner: changed from team to simon04
Status: newassigned

comment:12 Changed 3 months ago by Don-vip

@Simon: Don't we need setters that take a String argument for all non-String preset fields?

comment:13 Changed 3 months ago by simon04

Resolution: fixed
Status: assignedclosed

In 16180/josm:

fix #18954, see #18864 - TaggingPresetReader: read short types

comment:14 Changed 3 months ago by simon04

In 16181/josm:

see #18954, see #18864 - Introduce StringParser for parsing various types

comment:15 Changed 3 months ago by Don-vip

Nice! :)

comment:16 in reply to:  15 Changed 3 months ago by stoecker

Replying to Don-vip:

Nice! :)

Yeah, that code was ugly.

comment:17 Changed 3 months ago by simon04

In 16184/josm:

see #18954, see #18864 - Introduce GenericParser for Cascade.convertTo

comment:18 Changed 3 months ago by simon04

In 16188/josm:

see #18954, see #18864 - fix SonarQube issues

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.