Modify

Opened 3 months ago

Closed 3 months ago

#18937 closed enhancement (fixed)

water area inside water area

Reported by: Geimas5 Owned by: Don-vip
Priority: normal Milestone: 20.03
Component: Core validator Version: latest
Keywords: water Cc:

Description

Attached is a case that would be nice if was caught by the validation rules.

Attachments (1)

WaterValidationCase.osm (1.2 KB) - added by Geimas5 3 months ago.

Download all attachments as: .zip

Change History (4)

Changed 3 months ago by Geimas5

Attachment: WaterValidationCase.osm added

comment:1 Changed 3 months ago by Don-vip

Component: CoreCore validator
Keywords: water added

It's not an overlap but an identical shape. If we change the tags to building=yes we don't get "overlapping buildings" but "Building inside building" warning:

/* Building inside building (spatial test) */
*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] 
area[building][building!~/no|entrance/] {
  throwWarning: tr("Building inside building");
}

/* Building overlapping building (spatial test) */
area[building][building!~/no|entrance/]  area[building][building!~/no|entrance/] {
  throwWarning: tr("Overlapping buildings");
}

We have an overlap water area check, it works:

/* Overlapping areas (spatial test) */
area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
  set water_area;
}

/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/]  area:closed:areaStyle.water_area,
area:closed:areaStyle[landuse=reservoir]                         area:closed:areaStyle.water_area {
  throwWarning: tr("Overlapping Water Areas");
}

So what's missing is a "water area inside water area" check.

comment:2 Changed 3 months ago by Don-vip

Milestone: 20.03
Owner: changed from team to Don-vip
Status: newassigned
Summary: Overlapping water areaswater area inside water area
Type: defectenhancement

comment:3 Changed 3 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 16145/josm:

fix #18937 - add "water area inside water area" check

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.