Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18913 closed defect (fixed)

[Patch] Contradicting Changeset manager Captions

Reported by: Hb--- Owned by: team
Priority: trivial Milestone: 20.05
Component: Core Version:
Keywords: changeset Cc:

Description

The Changeset manager uses different captions for the same data in one dialog, see screenshot.

Suggestions are:

  • Replace "Changeset Management Dialog" with Changeset Manager.
  • Replace "User" and "Created by:" with Author resp. Author:.
  • Replace "Created on:" with Created at:.
  • Replace "Closed on:" with Closed at:.

The key "created_by" is nowadays used for the editor software.

I18n effects:

  1. "Changeset Management Dialog", "Created on:" and "Closed on:" would drop from translation.
  2. Closed at: would be new to translate.


  • TabularUnified trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheManager.java

    a b  
    285285    }
    286286
    287287    protected void build() {
    288         setTitle(tr("Changeset Management Dialog"));
     288        setTitle(tr("Changeset Manager"));
    289289        setIconImage(ImageProvider.get("dialogs/changeset", "changesetmanager").getImage());
    290290        Container cp = getContentPane();
    291291
  • TabularUnified trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetDetailPanel.java

    a b  
    152152        pnl.add(tfOpen, gc);
    153153        tfOpen.setEditable(false);
    154154
    155         //-- Created by:
     155        //-- Author:
    156156        gc.gridx = 0;
    157157        gc.gridy = 3;
    158158        gc.fill = GridBagConstraints.HORIZONTAL;
    159159        gc.weightx = 0.0;
    160         pnl.add(new JLabel(tr("Created by:")), gc);
     160        pnl.add(new JLabel(tr("Author:")), gc);
    161161
    162162        gc.fill = GridBagConstraints.HORIZONTAL;
    163163        gc.weightx = 1.0;
     
    170170        gc.gridy = 4;
    171171        gc.fill = GridBagConstraints.HORIZONTAL;
    172172        gc.weightx = 0.0;
    173         pnl.add(new JLabel(tr("Created on:")), gc);
     173        pnl.add(new JLabel(tr("Created at:")), gc);
    174174
    175175        gc.fill = GridBagConstraints.HORIZONTAL;
    176176        gc.gridx = 1;
     
    182182        gc.gridy = 5;
    183183        gc.fill = GridBagConstraints.HORIZONTAL;
    184184        gc.weightx = 0.0;
    185         pnl.add(new JLabel(tr("Closed on:")), gc);
     185        pnl.add(new JLabel(tr("Closed at:")), gc);
    186186
    187187        gc.fill = GridBagConstraints.HORIZONTAL;
    188188        gc.gridx = 1;
  • TabularUnified trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheTableColumnModel.java

    a b  
    3838        createColumn(2, tr("Open"), 25, -1);
    3939
    4040        // column 3 - User
    41         createColumn(3, tr("User"), 50, -1);
     41        createColumn(3, tr("Author"), 50, -1);
    4242
    4343        // column 4 - Created at
    4444        createColumn(4, tr("Created at"), 100, -1);

Change History (5)

by Hb---, 5 years ago

comment:1 by Don-vip, 5 years ago

Keywords: changeset added
Milestone: 20.04

comment:2 by simon04, 5 years ago

Resolution: fixed
Status: newclosed

In 16305/josm:

fix #18913 - Changeset Manager: improve i18n strings (patch by Hb---)

comment:3 by simon04, 5 years ago

Thanks for this patch!

comment:4 by Klumbumbus, 5 years ago

Milestone: 20.0420.05

Milestone renamed

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.