Modify

Opened 3 months ago

Closed 2 months ago

#18896 closed enhancement (fixed)

ImageryInfo: refactor/simplify/improve

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.03
Component: Core Version:
Keywords: yourkit performance Cc:

Description


Attachments (0)

Change History (5)

comment:1 Changed 3 months ago by simon04

Starting with r16092 org.openstreetmap.josm.data.imagery.ImageryInfo jdk.internal.loader.ClassLoaders$AppClassLoader 972 178_848 5_413_408

#18750 would be a low hanging fruit, but disputed.

comment:2 Changed 3 months ago by simon04

[o35353] – jmapviewer/Coordinate: unwrap Point2D to reduce memory consumption from 48 to 32

before: Coordinate jdk.internal.loader.ClassLoaders$AppClassLoader 81270 1300320 3_900_960
after:  Coordinate jdk.internal.loader.ClassLoaders$AppClassLoader 81270 2600640 2_600_640

Saves 1.3 MB of heap memory!

org.openstreetmap.josm.data.imagery.ImageryInfo jdk.internal.loader.ClassLoaders$AppClassLoader 972 178_848 4_113_088

Last edited 3 months ago by simon04 (previous) (diff)

comment:3 Changed 3 months ago by Don-vip

and removes a dependence on AWT, which is a good thing for #15229. In the long term I'd like to get rid of AWT/Swing in our data classes.

comment:4 Changed 3 months ago by simon04

In 16101/josm:

see #18896: ImageryInfo: use Utils.toUnmodifiableList and Utils.toUnmodifiableMap

before: org.openstreetmap.josm.data.imagery.ImageryInfo jdk.internal.loader.ClassLoaders$AppClassLoader 972 178_848 4_107_968
after:  org.openstreetmap.josm.data.imagery.ImageryInfo jdk.internal.loader.ClassLoaders$AppClassLoader 972 178_848 4_031_728
Last edited 3 months ago by simon04 (previous) (diff)

comment:5 Changed 2 months ago by simon04

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.