Opened 6 years ago

Last modified 5 years ago

#18892 new enhancement

Features missing in OpeningHoursParser compared to JS library — at Initial Version

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: opening_hours auto fix message Cc: simon04, SimonPoole

Description

In r15978 the switch from JS did take place, see #18140.

Some features got lost, namely:

  • option to automatically fix issues
  • human readable messages e.g.:
    • Encountered " <HOLIDAYS> "PH "" at line 1, column 26Was expecting: <EOF> for Fr-We,PH 10:00-17:00; Fr PH +1 day off
    • Holiday after weekday at line 1, column 10 for opening_hours=Mo-Su,PH 10:00-21:30
    • Encountered: <HYPHEN> "- " at line 1, column 14Was expecting: <EOF> for 10:00-17:00; Jan-Mai,Nov-Dec Mo off; PH,SH Mo 09:00-17:00

The automatically fix was a great feature and I will miss it.

The messages should display the string with highlighted errors instead of the line and column

In JS, the messages displayed the string from the start to the position the error occurred but that does not work for multiple errors. See #18807


Change History (0)

Note: See TracTickets for help on using tickets.