Changes between Initial Version and Version 2 of Ticket #18892


Ignore:
Timestamp:
2020-03-08T18:47:37+01:00 (4 years ago)
Author:
skyper
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18892 – Description

    initial v2  
    22
    33Some features got lost, namely:
    4 * option to automatically fix issues
     4* option to automatically fix some issues
     5 * e.g. all three examples mentioned [#example below]
     6
     7 The automatically fix was a great feature and I will miss it.
     8
    59* human readable messages e.g.:
    6  * `Encountered " <HOLIDAYS> "PH "" at line 1, column 26Was expecting: <EOF>` for `Fr-We,PH 10:00-17:00; Fr PH +1 day off`
     10 * `Encountered " <HOLIDAYS> "PH "" at line 1, column 26Was expecting: <EOF>` for `Fr-We,PH 10:00-17:00; Fr PH +1 day off` [=#example]
    711 * `Holiday after weekday at line 1, column 10` for `opening_hours=Mo-Su,PH 10:00-21:30`
    812 * `Encountered: <HYPHEN> "- " at line 1, column 14Was expecting: <EOF>` for `10:00-17:00; Jan-Mai,Nov-Dec Mo off; PH,SH Mo 09:00-17:00`
    913
    10 The automatically fix was a great feature and I will miss it.
     14 The messages should display the string with highlighted errors instead of the line and column
     15 In JS, the messages displayed the string from the start to the position the error occurred but that does not work for multiple errors. See #18807
    1116
    12 The messages should display the string with highlighted errors instead of the line and column
    13  In JS, the messages displayed the string from the start to the position the error occurred but that does not work for multiple errors. See #18807
    14  
     17* flagging all errors in one value
     18
     19 See https://github.com/simonpoole/OpeningHoursParser/issues/42