Modify

Opened 9 months ago

Closed 8 months ago

#18886 closed enhancement (fixed)

OsmReader: refactor/simplify/improve

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.03
Component: Core Version:
Keywords: yourkit performance Cc:

Description


Attachments (0)

Change History (8)

comment:1 Changed 9 months ago by simon04

First finding: parsing https://download.geofabrik.de/europe/montenegro-latest.osm.bz2 spends 15s in org.openstreetmap.josm.data.osm.Node#updateDirectionFlags (nodes only) out of a total 149s for org.openstreetmap.josm.io.OsmReader#parse

comment:2 Changed 9 months ago by simon04

In 16077/josm:

see #18886 - Node.updateDirectionFlags: override to improve performance

comment:3 Changed 9 months ago by simon04

In 16080/josm:

see #18886 - AbstractReader.parseTimestamp: use LRU cache

2016ms were spent in parseTimestamp out of 17735ms spent in parseNode. This change reduces the time to 955ms.

Last edited 9 months ago by simon04 (previous) (diff)

comment:4 Changed 9 months ago by Don-vip

Owner: set to simon04
Status: assignednew

comment:5 Changed 9 months ago by Don-vip

While you're looking at JOSM performance, do you understand why the JOSM performance tests no longer work?
https://josm.openstreetmap.de/jenkins/job/JOSM-Performance/

They are broken for several months/years but I failed to understand why.

EDIT: the last successful build was with r13170: https://josm.openstreetmap.de/jenkins/job/JOSM-Performance/175/

EDIT2: I found again my call for help: https://josm.openstreetmap.de/ticket/15310#comment:43

Last edited 9 months ago by Don-vip (previous) (diff)

comment:6 in reply to:  2 Changed 9 months ago by simon04

Replying to simon04:

In 16077/josm:

see #18886 - Node.updateDirectionFlags: override to improve performance

Verified: reversing https://www.openstreetmap.org/way/246449783 still shows dialog for direction-dependent railway signals.

comment:7 Changed 9 months ago by simon04

Status: newassigned

comment:8 Changed 8 months ago by simon04

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.