[Patch] Allow to opt-out from JOSM's certificate amendment

[simon04]

Previously on the heap:

sun.security.provider.X509Factory 1_084_648

[stoecker]

Please give a reason why this should be possible.

[simon04]

Reduced initialization time, reduced memory consumption, reduced complexity (for users not needed the supplementary certificates), reduced attack surface (for suspicious users).

[stoecker]

Replying to simon04:

Reduced initialization time, reduced memory consumption

Small compared to immense amount of stuff we do

reduced complexity (for users not needed the supplementary certificates)

An opt-out icreased the complexity - it does not reduce it.

, reduced attack surface (for suspicious users).

We don't decide about certs ourself. We only override the slowness of the Java world to follow the rest of the world.

If I weight the minimal advantages against the disadvantages we will have to deal with when users fail to load perfectly valid imagery I don't see much benefit in this.

[Don-vip]

It is already possible if you run JOSM with --offline=certificates. What do you want more?

[Don-vip]

And we have also this property since r9995:

    /**
     * Add missing root certificates to the list of trusted certificates for TLS connections.
     * @throws IOException if an I/O error occurs
     * @throws GeneralSecurityException if a security error occurs
     */
    public static void addMissingCertificates() throws IOException, GeneralSecurityException {
        if (!Config.getPref().getBoolean("tls.add-missing-certificates", true))
            return;

[simon04]

I'm stupid, it was just in front of my eyes, but I overlooked it. Thanks for the clarification, Vincent!