Modify ↓

Opened 4 years ago

Closed 4 years ago

#18870 closed enhancement (fixed)

[Patch] Suppress multiple requests dialog for only one server request in DownloadAlong

Reported by: Hb--- Owned by: team
Priority: minor Milestone: 20.03
Component: Core Version:
Keywords: i18n download along Cc:

Description

Even if only one single server request is needed a confirmation dialog is raised in /browser/josm/trunk/src/org/openstreetmap/josm/actions/DownloadAlongAction.java#L135

This seems inappropriate because the user had confirmed that he want to connect to a server just the dialog before.

The patch includes the plural form for I18n and is completely untested.

Attachments (1)

DownloadAlongAction.patch​ (1.8 KB ) - added by Hb--- 4 years ago.

Download all attachments as: .zip

Change History (5)

by Hb---, 4 years ago

Attachment: DownloadAlongAction.patch​ added

comment:1 by Don-vip, 4 years ago

What's the point of using trn for a string only translated in its plural form? It's useless translation work.

comment:2 by simon04, 4 years ago

Keywords: i18n added

Some languages have complex plural rules (org.openstreetmap.josm.tools.I18n#pluralEval).

comment:3 by Don-vip, 4 years ago

Keywords: download along added
Milestone: → 20.03
Priority: normal → minor

Ah, right.

comment:4 by simon04, 4 years ago

Resolution: → fixed
Status: new → closed

In 16066/josm:

fix #18870 - DownloadAlongAction: suppress multiple requests dialog for only one server request in DownloadAlong (patch by Hb---, modified)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.