NPE in Help Browser when posting

[Hb---]

What steps will reproduce the problem?

1. Open Help
2. Click on current link to #18845
3. Click on a Reply button, write some text
4. Click on Preview/Submit changes

What is the expected result?

Comment posted as anonymous.

What happens instead?

NPE

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-26 10:50:27 +0100 (Wed, 26 Feb 2020)
Build-Date:2020-02-26 09:52:41
Revision:15937
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15937 de) Windows 7 64-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 1514 MB / 3641 MB (796 MB allocated, but free)
Java version: 1.8.0_212-b03, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Screen: \Display0 1280x1024
Maximum Screen Size: 1280x1024
VM arguments: [-Djosm.dir.name=JOSMhb]

Plugins:
+ PicLayer (35313)
+ apache-commons (35092)
+ buildings_tools (35248)
+ continuosDownload (91)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ measurement (35248)
+ opendata (35330)
+ photo_geotagging (35313)
+ photoadjust (35313)
+ print (35248)
+ reverter (35313)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ turnrestrictions (35313)
+ utilsplugin2 (35334)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/hiking_routes_with_trail_marking&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Presets_Hafen.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/AU.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- W: Failed to parse taginfo data geofabrik-index-v1-nogeom.json
- W: Warnung: Das Absuchen der Datei 'site-svn.openstreetmap.org-_applications_editors_josm_plugins_opendata_modules.txt' nach Modulinformationen ist fehlgschlagen. Überspringe.
- E: Fehler beim Laden des Bildes 'https://josm.openstreetmap.de/browser/trunk/images/selectall.svg?format=raw'
- E: Fehler beim Laden des Bildes 'https://josm.openstreetmap.de/browser/trunk/images/selectall.svg?format=raw'
- E: Fehler beim Laden des Bildes 'https://josm.openstreetmap.de/browser/trunk/images/data/node.svg?format=raw'
- E: Fehler beim Laden des Bildes 'https://josm.openstreetmap.de/browser/trunk/images/data/way.svg?format=raw'
- E: Fehler beim Laden des Bildes 'https://josm.openstreetmap.de/browser/trunk/images/data/closedway.svg?format=raw'
- E: Fehler beim Laden des Bildes 'https://josm.openstreetmap.de/browser/trunk/images/svpDown.svg?format=raw'
- E: Fehler beim Laden des Bildes 'https://josm.openstreetmap.de/browser/trunk/images/svpDown.svg?format=raw'
- E: Handled by bug report queue: java.lang.NullPointerException


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (17) of main
java.lang.NullPointerException
	at java.net.URLEncoder.encode(URLEncoder.java:204)
	at java.net.URLEncoder.encode(URLEncoder.java:170)
	at javax.swing.text.html.FormView.appendBuffer(FormView.java:819)
	at javax.swing.text.html.FormView.loadSelectData(FormView.java:801)
	at javax.swing.text.html.FormView.loadElementDataIntoBuffer(FormView.java:703)
	at javax.swing.text.html.FormView.getFormData(FormView.java:672)
	at javax.swing.text.html.FormView.actionPerformed(FormView.java:433)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
	at java.awt.Component.processMouseEvent(Component.java:6539)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
	at java.awt.Component.processEvent(Component.java:6304)
	at java.awt.Container.processEvent(Container.java:2239)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2297)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4904)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4535)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4476)
	at java.awt.Container.dispatchEventImpl(Container.java:2283)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84)
	at java.awt.EventQueue$4.run(EventQueue.java:733)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[Don-vip]

The ticket #18845 has no "version" field filled with a value. When pressing submit, a decent navigator sets a "field_version=" POST argument with an empty value. Java's FormView, however, chokes with an NPE. Nothing we can do in JOSM unless submitting the bug to OpenJDK.

Debug value of internal StringBuilder when the NPE occurs:

__FORM_TOKEN=d71effad691eafc15f4c70c6&field_summary=reorganization+of+data%28_nodist%29%2C+images%28_nodist%29%2C+styles%28_nodist%29%2C+IDE+and+native+files+in+a+more+practical+file+tree&field_type=enhancement&field_priority=major&field_milestone=20.03&field_component=Core&field_version=}}}

[Don-vip]

Reported to Oracle with internal review ID : 9063948.
EDIT: ​javabug:8240877

[Don-vip]

Wow it was fast. Oracle fixed the bug in build 19 of JDK 15.