Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#18853 closed defect (fixed)

[PATCH] Close OsmWriter after writing XML output streams (Sonar)

Reported by: hiddewie Owned by: team
Priority: minor Milestone: 20.03
Component: Core Version:
Keywords: Cc:

Attachments (1)

osm-writer.patch (10.0 KB) - added by hiddewie 3 months ago.

Download all attachments as: .zip

Change History (8)

Changed 3 months ago by hiddewie

Attachment: osm-writer.patch added

comment:1 Changed 3 months ago by hiddewie

Summary: [PATCH] Close OsmWriter after writing XML output streams[PATCH] Close OsmWriter after writing XML output streams (Sonar)

comment:2 Changed 3 months ago by Don-vip

Milestone: 20.03
Priority: trivialminor

comment:3 Changed 3 months ago by Don-vip

Type: enhancementdefect

comment:4 Changed 3 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 16088/josm:

fix #18853 - Close OsmWriter after writing XML output streams (patch by hiddewie, modified)

comment:5 Changed 3 months ago by Don-vip

Thanks for the patch! I only applied ValidatorErrorWriter, because stream is not meant to be closed in OsmDataSessionExporter.

comment:6 Changed 3 months ago by hiddewie

OK, good to know. In OsmDataSessionExporter: the stream should maybe not be closed, but the it would be logical to close the associated writers (without closing the stream) in the scope where they are created.

comment:7 Changed 3 months ago by Don-vip

I did not check, but I think the stream is closed if you close the writer.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.