Opened 6 years ago

Last modified 6 years ago

#18807 closed defect

Wrong fix off opening_hour — at Version 3

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report opening_hours PH Cc: ypid23

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have an object with opening_hours=Fr-We,PH 10:00-17:00; Fr PH +1 days off. If Thursday is holiday, Friday is off.
  2. run validator

What is the expected result?

No warning

What happens instead?

Two warnings for one issue.

  • Opening hours syntax - opening_hours - Fr-We,PH 10:00-17:00; PH +1 day Fr <--- (The selector "weekday" was switched with the selector "holiday" for readability and compatibility reasons.)
  • Opening hours syntax - opening_hours - Fr-We,PH 10:00-17:00; PH +1 day <--- (The selector "holiday" was switched with the selector "weekday" for readability and compatibility reasons.)

The auto fix changes the value to opening_hours=Fr-We,PH 10:00-17:00; PH +1 day Fr off which in my understanding is something different but I did not find an example on the wiki.

Please provide any additional information below. Attach a screenshot if possible.

At least two warnings for one issue is a bug

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-28 00:58:00 +0100 (Fri, 28 Feb 2020)
Revision:15951
Build-Date:2020-02-28 02:31:00
URL:https://josm.openstreetmap.de/svn/trunk

Change History (3)

comment:1 by skyper, 6 years ago

Keywords: opening_hours added; opening_hour removed

comment:2 by Don-vip, 6 years ago

Cc: ypid23 added

comment:3 by skyper, 6 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.