Modify

Opened 3 months ago

Closed 3 months ago

#18806 closed defect (fixed)

Setting option disappears after change

Reported by: Hanikatu Owned by: team
Priority: normal Milestone: 20.03
Component: Core Version:
Keywords: template_report regression Cc: taylor.smock, GerdP

Description

What steps will reproduce the problem?

  1. Go to the presets setting and change something and than click 'OK'
  2. Now Click on 'Presets'
  3. -> Settings are gone

What is the expected result?

The settings are available

What happens instead?

The settings are gone

Please provide any additional information below. Attach a screenshot if possible.


URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-26 10:50:27 +0100 (Wed, 26 Feb 2020)
Build-Date:2020-02-26 09:52:41
Revision:15937
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15937 de) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 1696 MB / 3628 MB (1268 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1440x900
Maximum Screen Size: 1440x900
VM arguments: [-Duser.home=%UserProfile%]
Dataset consistency test: No problems found

Plugins:
+ RoadSigns (35313)
+ buildings_tools (35248)
+ undelete (35313)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Surveillance&zip=1
+ D:\Benutzer\Desktop\alt\OpenStreetMap\JOSM\Vorlagen\Lichtvorlage\Licht.zip
+ D:\Benutzer\Desktop\alt\OpenStreetMap\JOSM\Vorlagen\Strommastvorlage\Strommast_vorlage.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/RecyclingMaterials&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- D:\Benutzer\Desktop\alt\OpenStreetMap\JOSM\Kartenstiel\oberfläche\oberfläche.mapcss
- D:\Benutzer\Desktop\alt\OpenStreetMap\JOSM\Kartenstiel\häuser\häuser.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
+ D:\Benutzer\Desktop\alt\OpenStreetMap\JOSM\Kartenstiel\Strommast\Strommast.mapcss
+ D:\Benutzer\Desktop\alt\OpenStreetMap\JOSM\Kartenstiel\Richtung\ausrichtung.mapcss
+ D:\Benutzer\Desktop\alt\OpenStreetMap\JOSM\Kartenstiel\Licht\Licht.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- E: Fehler beim Laden des Bildes 'traffic_signs_presets/ES_tertiary.png'
- W:  Tertiary: Could not get presets icon traffic_signs_presets/ES_tertiary.png
- E: Fehler beim Laden des Bildes 'traffic_signs_presets/ES_tertiary.png'
- W:  Tertiary: Could not get presets icon traffic_signs_presets/ES_tertiary.png
- E: Fehler beim Laden des Bildes 'traffic_signs_presets/ES_tertiary.png'
- W:  Tertiary: Could not get presets icon traffic_signs_presets/ES_tertiary.png
- E: Fehler beim Laden des Bildes 'traffic_signs_presets/ES_tertiary.png'
- W:  Tertiary: Could not get presets icon traffic_signs_presets/ES_tertiary.png

Attachments (2)

Vorlagen-Bug.png (13.8 KB) - added by Hanikatu 3 months ago.
18806.patch (4.6 KB) - added by taylor.smock 3 months ago.
Add standard options when initialized

Download all attachments as: .zip

Change History (7)

Changed 3 months ago by Hanikatu

Attachment: Vorlagen-Bug.png added

comment:1 Changed 3 months ago by Klumbumbus

Cc: taylor.smock added

Sounds like a regression of #18381.

comment:2 Changed 3 months ago by Don-vip

Cc: GerdP added

comment:3 Changed 3 months ago by Don-vip

Keywords: regression added
Milestone: 20.03

Changed 3 months ago by taylor.smock

Attachment: 18806.patch added

Add standard options when initialized

comment:4 Changed 3 months ago by Klumbumbus

Btw, offtopic: it would be fabulous if presets would automatically reload when the file is changed externally, similar to mapcss and validator files. Currently you need to trigger the reload by changing soomething in the preset preferences.

comment:5 Changed 3 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 15958/josm:

fix #18806 - see #18381 - fix tagging presets menu initialization (patch by taylor.smock)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.