[PATCH RFC] Allow layers to determine autosave functionality

[taylor.smock]

The patch currently:
1) Modifies ImageData/NoteData to implement Data, but they return an empty collection of DataSources
2) Modifies AbstractModifiableLayer to have a function for autosave (takes a file argument), return false by default (to indicate not saved and not savable). It also adds an abstract method to get the data from the layer. The only addon I found to be affected by this was OpenQA, which can be modified by me.
3) AutosaveTask now just has a single Set<Data> instead of one each for DataSet/NodeData.
4) There is now a global instance of AutosaveTask, once it has been initialized. I should probably change all calls to be to getInstance.
5) It iterates through the layers, using the same if (changedData.remove) syntax, and then calls the layer's autosave method.
6) AutosaveTask also has a new method to indicate that data has been updated
7) Affected layers now implement getData and autosave, where the file was previously autosaved

EDIT: Mapillary is also affected

[taylor.smock]

Initial patch (pre-existing tests pass)

[Don-vip]

Replying to taylor.smock:

4) There is now a global instance of AutosaveTask, once it has been initialized. I should probably change all calls to be to getInstance.

Why? I don't see the need.

[taylor.smock]

I haven't done that yet (in fact, I don't remember why I was thinking I might have to do it). (I'm assuming you are talking about the getInstance I was referring to).

[Don-vip]

I don't see the need to have a global instance of AutosaveTask.

[taylor.smock]

Remove unnecessary global instance

[Klumbumbus]

Milestone renamed

[simon04]

I'll modify you patch to make org.openstreetmap.josm.gui.layer.AbstractModifiableLayer#getData non-abstract and return null. Otherwise the following plugins would need to be adapted:

• ​https://trac.openstreetmap.org/browser/subversion/applications/editors/josm/plugins/MicrosoftStreetside/src/org/openstreetmap/josm/plugins/streetside/StreetsideLayer.java
• ​https://gitlab.com/gokaart/JOSM_OpenQA/blob/master/src/main/java/com/kaart/openqa/ErrorLayer.java
• ​https://gitlab.com/JOSM/plugin/Mapillary/blob/master/src/main/java/org/openstreetmap/josm/plugins/mapillary/gui/layer/MapillaryLayer.java

[simon04]

In 16548/josm:

fix #18801 - Allow layers to determine autosave functionality (patch by taylor.smock, modified)

[taylor.smock]

Replying to simon04:

I'll modify you patch to make org.openstreetmap.josm.gui.layer.AbstractModifiableLayer#getData non-abstract and return null. Otherwise the following plugins would need to be adapted:

• ​https://trac.openstreetmap.org/browser/subversion/applications/editors/josm/plugins/MicrosoftStreetside/src/org/openstreetmap/josm/plugins/streetside/StreetsideLayer.java
• ​https://gitlab.com/gokaart/JOSM_OpenQA/blob/master/src/main/java/com/kaart/openqa/ErrorLayer.java
• ​https://gitlab.com/JOSM/plugin/Mapillary/blob/master/src/main/java/org/openstreetmap/josm/plugins/mapillary/gui/layer/MapillaryLayer.java

Fair enough (I could have modified two of the plugins on that list to work with this patch, but MS Streetside would still be a problem).