Opened 5 years ago

Last modified 5 years ago

#18731 closed enhancement

[PATCH] There should be a method to search for all primitives inside a bbox — at Version 2

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 20.02
Component: Core Version:
Keywords: Cc:

Description (last modified by taylor.smock)

Currently, if I want to check all primitives in a bbox, I have to create a list and then make a call for searchNodes, searchWays, and searchRelations.

I'm marking this as an RFC since I think it would be better to put this in the OsmData class with a default method, but I don't know if it is worth the effort (I don't know how to cleanly check if N/W/R extend O).

I also haven't implemented any tests for it.

Change History (4)

by taylor.smock, 5 years ago

Attachment: 18731.patch​ added

Initial patch for searchPrimitives

comment:1 by Don-vip, 5 years ago

It's ok in DataSet. Can be moved to OsmData later if there's a need for.

by taylor.smock, 5 years ago

Attachment: 18138.1.patch​ added

Add tests and fix an issue with a possible NPE (if bbox is null, there is an error in searchNodes)

comment:2 by taylor.smock, 5 years ago

Description: modified (diff)
Summary: [PATCH RFC] There should be a method to search for all primitives inside a bbox → [PATCH] There should be a method to search for all primitives inside a bbox
Note: See TracTickets for help on using tickets.