[PATCH] There should be a method to cycle through layers

[taylor.smock]

I originally used CTRL+[/CTRL+] for the layer switches, but I figured SHIFT+{/SHIFT+} would be better ([ -> { due to SHIFT converting [ to {).

I haven't written tests yet -- I'm doing that now.

I probably didn't pick the right class to instantiate the new class in (I'm currently using LayerListDialog, but I figured that was probably the best place to put it).

[taylor.smock]

Initial patch (no tests)

[taylor.smock]

Switch back to [ and ] from { and } along with tests

[taylor.smock]

Ping

[Don-vip]

codestyle fixed. Beware to please the Shortcut parser

[Don-vip]

I've modified your patch to respect checkstyle rules and make sure the Shortcut parser will work properly. But I got three unit test failures on 6:

[taylor.smock]

Split cycle up/cycle down actions into separate files, fix shortcut issues (single line), and some other pmd issues

[taylor.smock]

I put it in the MapWithAI plugin temporarily, and it also complained about the tests. I fixed them, but forgot to update the patch here.
It turns out that (for whatever reason), the CI environment wasn't passing the modifier keys, IIRC. I ended up splitting the actions up, instead of trying to have one class (it worked on Mac OS X, but not in the CI environment).

I forgot to bring the changes back over to this bug report. I should have, so you wouldn't have duplicated some of the work.

[Don-vip]

In 15923/josm:

fix #18638 - add a method to cycle through layers (patch by taylor.smock, modified)

[skyper]

Milestone 20.2

[taylor.smock]

I forgot to add the initialization code to the patch.

[taylor.smock]

Actually initialize the actions (in LayerListDialog)

[Don-vip]

In 15929/josm:

fix #18638 - Initialize the cycle layer actions in LayerListDialog (patch by taylor.smock)

[Zverikk]

By the way, [ and ] keys are used by the "todo" plugin to cycle through the todo list.

[taylor.smock]

I knew that, which is why I used shift + [/shift + ] (which translates the ] to } and [ to {, which made testing interesting).

[Zverikk]

Ah, indeed, thank you.

[Hb---]

The names for the keyboard shortcuts and for the action seem not consistent to each other. Currently we have

Cycle layers up for the shortcut
Cycle layer up for the action and
Cycle up through layers for the hint.

Cycle layers down for the shortcut
Cycle layers for the down action and
Cycle through layers for the hint

Are different names for the shortcut and for the action necessary?

Why is plural used when only one layer is affected? This good action is not as shuffling the background layers around each other.

Suggestion:
Cycle layer up for shortcut and action
Cycle through data layers upwards for the hint.

Cycle layer down for the shortcut and action
Cycle through data layers downwards for the hint

[GerdP]

FYI: I see this message in some unit tests, e.g. JoinAreasActionTest

2020-03-06 09:40:10.255 INFORMATION: Registered toolbar action cycle-layer overwritten: org.openstreetmap.josm.gui.dialogs.layer.CycleLayerUpAction gets org.openstreetmap.josm.gui.dialogs.layer.CycleLayerDownAction

[GerdP]

My patch fixes only the issue reported in comment:17

[taylor.smock]

Modify GerdP's patch to add consistency in action UI descriptions

[Don-vip]

In 16090/josm:

fix #18638 - add consistency in action UI descriptions (patch by taylor.smock)

[Don-vip]

In 16097/josm:

see #18638 - checkstyle