Combine Way does not generate conflict when joining maxspeed with maxspeed:forward in expert mode

[simon04]

What steps will reproduce the problem?

• Way 1: highway=residential maxspeed=50
• Way 2: highway=residential maxspeed=50 maxspeed:forward=50 maxspeed:backward=30
• Select both ways
• Run "Combine Ways"

What is the expected result?

Conflict dialog (or warning) appears

What happens instead?

Ways are combined silently

Please provide any additional information below. Attach a screenshot if possible.

Revision:15742
Is-Local-Build:true
Build-Date:2020-01-20 23:22:35

Identification: JOSM/1.5 (15742 SVN en_GB) Linux Arch Linux
Memory Usage: 588 MB / 3972 MB (363 MB allocated, but free)
Java version: 11.0.6+10, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 3840x2160
Maximum Screen Size: 3840x2160
VM arguments: [-agentlib:jdwp=transport=dt_socket,address=127.0.0.1:35787,suspend=y,server=n, -Djosm.home=<josm.pref>, -javaagent:/usr/share/idea/plugins/Groovy/lib/agent/gragent.jar, -javaagent:/usr/share/idea/plugins/java/lib/rt/debugger-agent.jar, -Dfile.encoding=UTF-8]
Program arguments: [--set=expert=true, --set=iso.dates=true, --set=debug.edt-checker.enable=true, /tmp/b.osm]
Dataset consistency test: No problems found

Plugins:
+ wikipedia (1.1.3)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [WMTS_BLOCK_v2] Resetting cache
- E: Failed to locate image 'images/thetha.svg'

[skyper]

screenshot

[skyper]

Cannot reproduce!
Sure you did not disable the warning ?

[simon04]

Ah, I've been working in the expert mode, which seems to prevent this dialog.
Ah, it was me introducing this behaviour in #7513 eight years ago.

Maybe the warning should also be shown to experts?

[skyper]

Replying to simon04:

Ah, I've been working in the expert mode, which seems to prevent this dialog.
Ah, it was me introducing this behaviour in #7513 eight years ago.

Forgot about it, too. Luckily, I tested with empty preferences.

Maybe the warning should also be shown to experts?

+1
Still needs some attention, though, see #7513.

[skyper]

Should these tag combinations conflicts not be handled like conflicts in values of one key and the Tags/Memberships Conflict Dialog open ?