Modify

Opened 3 months ago

Last modified 2 months ago

#18597 new defect

Combine Way does not generate conflict when joining maxspeed with maxspeed:forward in expert mode

Reported by: simon04 Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: combine expert Cc:

Description

What steps will reproduce the problem?

  • Way 1: highway=residential maxspeed=50
  • Way 2: highway=residential maxspeed=50 maxspeed:forward=50 maxspeed:backward=30
  • Select both ways
  • Run "Combine Ways"

What is the expected result?

Conflict dialog (or warning) appears

What happens instead?

Ways are combined silently

Please provide any additional information below. Attach a screenshot if possible.

Revision:15742
Is-Local-Build:true
Build-Date:2020-01-20 23:22:35

Identification: JOSM/1.5 (15742 SVN en_GB) Linux Arch Linux
Memory Usage: 588 MB / 3972 MB (363 MB allocated, but free)
Java version: 11.0.6+10, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 3840x2160
Maximum Screen Size: 3840x2160
VM arguments: [-agentlib:jdwp=transport=dt_socket,address=127.0.0.1:35787,suspend=y,server=n, -Djosm.home=<josm.pref>, -javaagent:/usr/share/idea/plugins/Groovy/lib/agent/gragent.jar, -javaagent:/usr/share/idea/plugins/java/lib/rt/debugger-agent.jar, -Dfile.encoding=UTF-8]
Program arguments: [--set=expert=true, --set=iso.dates=true, --set=debug.edt-checker.enable=true, /tmp/b.osm]
Dataset consistency test: No problems found

Plugins:
+ wikipedia (1.1.3)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [WMTS_BLOCK_v2] Resetting cache
- E: Failed to locate image 'images/thetha.svg'

Attachments (1)

josm_combine_confirm.png (29.6 KB) - added by skyper 3 months ago.
screenshot

Download all attachments as: .zip

Change History (5)

Changed 3 months ago by skyper

Attachment: josm_combine_confirm.png added

screenshot

comment:1 Changed 3 months ago by skyper

Cannot reproduce!
Sure you did not disable the warning ?

screenshot

comment:2 Changed 3 months ago by simon04

Keywords: combine expert added; template_report removed
Summary: Combine Way does not generate conflict when joining maxspeed with maxspeed:forwardCombine Way does not generate conflict when joining maxspeed with maxspeed:forward in expert mode

Ah, I've been working in the expert mode, which seems to prevent this dialog.
Ah, it was me introducing this behaviour in #7513 eight years ago.

Maybe the warning should also be shown to experts?

comment:3 in reply to:  2 Changed 3 months ago by skyper

Replying to simon04:

Ah, I've been working in the expert mode, which seems to prevent this dialog.
Ah, it was me introducing this behaviour in #7513 eight years ago.

Forgot about it, too. Luckily, I tested with empty preferences.

Maybe the warning should also be shown to experts?

+1
Still needs some attention, though, see #7513.

comment:4 Changed 2 months ago by skyper

Should these tag combinations conflicts not be handled like conflicts in values of one key and the Tags/Memberships Conflict Dialog open ?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to simon04
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.