Modify

Opened 3 months ago

Closed 3 months ago

#18539 closed enhancement (wontfix)

[Patch] Add amenity default for scuba diving

Reported by: simon04 Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: sport diving scuba Cc: hiddewie

Attachments (1)

56.patch (860 bytes) - added by simon04 3 months ago.

Download all attachments as: .zip

Change History (6)

Changed 3 months ago by simon04

Attachment: 56.patch added

comment:1 Changed 3 months ago by simon04

Cc: hiddewie added

comment:2 Changed 3 months ago by Klumbumbus

I don't like that patch. sport=scuba_diving and amenity=dive_centre are usually not at the same position at least not on the same osm object. These two tags should not be married in the preset.
No objection to add amenity=dive_centre as a separate preset though, if we find an icon. Maybe simply another color variant of source:trunk/images/presets/sport/scuba_diving.svg and source:trunk/images/presets/shop/scuba_diving.svg .

comment:3 Changed 3 months ago by Don-vip

Keywords: sport diving scuba added

comment:4 Changed 3 months ago by Klumbumbus

amenity=dive_centre added in r15689.

comment:5 Changed 3 months ago by Klumbumbus

Resolution: wontfix
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.